Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests with minimum version for Python 3.10 and 3.11 #4199

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

HideakiImamura
Copy link
Member

Motivation

To fix the CI.

The latest release of setuptools breaks the installation of libraries using numpy.distutils. See pypa/setuptools#3693 and numpy/numpy#22623.

I tried followings in #4198, but failed.

  • Constraint the version of setuptools to <65.6.0 (the latest one) on the workflow file of GitHub Actions
  • Constraint the version of numpy to <1.23.5 (the latest one) on the workflow file of GitHub Actions
  • Constraint the version of setuptools to <60.0 (the latest one) on the workflow file of GitHub Actions, since numpy officially supports setuptools<60.0
  • Constraint the version of setuptools to <65.6.0 (the latest one) on the setup.py

I found that the errors only occur for tests with minimum version and Python 3.10 and 3.11. This PR suggests a hot fix to avoid the tests with minimum version for Python 3.10 and 3.11.

Description of the changes

  • Avoid tests with minimum version for Python 3.10 and 3.11

@HideakiImamura HideakiImamura added the CI Continuous integration. label Nov 21, 2022
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata added this to the v3.1.0 milestone Nov 21, 2022
@c-bata
Copy link
Member

c-bata commented Nov 21, 2022

Let me merge this PR with 1 approval since this PR is a blocker of others.

@c-bata c-bata merged commit ebcd37f into optuna:master Nov 21, 2022
@HideakiImamura HideakiImamura deleted the hotfix-setuptools-65.6.0 branch June 9, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants