Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test_pop_waiting_trial_thread_safe on RedisStorage #4119

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Skip test_pop_waiting_trial_thread_safe on RedisStorage #4119

merged 1 commit into from
Nov 6, 2022

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Nov 4, 2022

Motivation

In #4118, test_pop_waiting_trial_thread_safe is failed with RedisStorage.

=========================== short test summary info ============================
FAILED tests/study_tests/test_study.py::test_pop_waiting_trial_thread_safe[redis] - assert 1 == 10

Description of the changes

Skip test_pop_waiting_trial_thread_safe on RedisStorage.

@c-bata c-bata changed the title Skip to test pop_waiting_trial on RedisStorage Skip test_pop_waiting_trial_thread_safe on RedisStorage Nov 4, 2022
@c-bata c-bata marked this pull request as ready for review November 4, 2022 08:36
@c-bata c-bata mentioned this pull request Nov 4, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022 •
edited

Codecov Report

Merging #4119 (62b1f58) into master (bccb63d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4119   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files         161      161           
  Lines       12655    12655           
=======================================
  Hits        11403    11403           
  Misses       1252     1252

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@c-bata c-bata force-pushed the skip-pop-waiting-trial-test-for-redis branch from cb93e89 to 62b1f58 Compare November 4, 2022 10:03
HideakiImamura
HideakiImamura approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura added the test Unit test. label Nov 6, 2022
knshnb
knshnb approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@knshnb knshnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

@knshnb knshnb added this to the v3.1.0 milestone Nov 6, 2022
@knshnb knshnb merged commit e467683 into optuna:master Nov 6, 2022
@c-bata c-bata deleted the skip-pop-waiting-trial-test-for-redis branch November 6, 2022 03:52
@c-bata c-bata mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knshnb knshnb knshnb approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees
No one assigned
Labels
test Unit test.
Projects
None yet
Milestone
v3.1.0-b0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c-bata @codecov-commenter @knshnb @HideakiImamura