Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Ubuntu version to 20.04 in Tests and Tests (Storage with server) #4118

Merged

Conversation

HideakiImamura
Copy link
Member

@HideakiImamura HideakiImamura commented Nov 4, 2022

Motivation

Fix the CI error in the master. According to actions/setup-python#401 (comment), we should add an environment variable AGENT_TOOLSDIRECTORY. The error seems to be fixed in my forked repo. This is a fix for the self-hosted runners. Sorry for the confusion.

The current CI of the master branch fails due to the installation fail of Python 3.6. This is because that the ubuntu-latest has been changed from 20.04 to 22.04. So, I will pin the version to 20.04 in the failing workflow: Tests and Tests (Storage with server).

Description of the changes

  • Pin ubuntu version to 20.04 in the CI workflows Tests and Tests (Storage with server).

@HideakiImamura HideakiImamura added the CI Continuous integration. label Nov 4, 2022
@HideakiImamura
Copy link
Member Author

Sorry, the above issue and solution is for the self-hosted runners.

@codecov-commenter
Copy link

Codecov Report

Merging #4118 (6ee95a3) into master (a879936) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4118   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         161      161           
  Lines       12655    12655           
=======================================
  Hits        11401    11401           
  Misses       1254     1254           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HideakiImamura
Copy link
Member Author

I have decided to remove the Python 3.6 from the Tests and Tests (Storage with server) to pass the CI, since I have no idea why Python 3.6 cannot be installed. This will be investigated afterward. I will create an issue.

@HideakiImamura
Copy link
Member Author

Let me change the PR title and description to match the current status of this PR.

@HideakiImamura HideakiImamura changed the title Fix CI "Error: Version 3.6 with arch x64 not found" Avoid running Tests and Tests (Storage with server) with Python 3.6 to pass the CI Nov 4, 2022
@c-bata
Copy link
Member

c-bata commented Nov 4, 2022

Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ubuntu-latest dropped Python 3.6 support. actions/runner-images#6399

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@c-bata c-bata merged commit bccb63d into optuna:master Nov 4, 2022
@not522 not522 changed the title Avoid running Tests and Tests (Storage with server) with Python 3.6 to pass the CI Pin Ubuntu version to 20.04 in Tests and Tests (Storage with server) Nov 6, 2022
@not522 not522 added this to the v3.1.0 milestone Nov 6, 2022
contramundum53 pushed a commit to contramundum53/optuna that referenced this pull request Nov 30, 2022
…n-not-supported

Avoid running `Tests` and `Tests (Storage with server)` with Python 3.6 to pass the CI
@HideakiImamura HideakiImamura deleted the fix-ci-error-python-not-supported branch June 9, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants