Avoid installing the latest MLfow to prevent doctests from failing #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himkt
changed the title
|
optuna/optuna/integration/mlflow.py Line 69 in 51b5483 We expect callback to log a message by the above format. ref. mlflow/mlflow#5012 pointed out by @nzw0301 We have to follow the change in MLflow. |
|
We'll be able to update our doctest to follow the change in MLflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Although I haven't investigated the cause yet, the doctest was failing with the latest MLflow.
https://github.com/optuna/optuna/runs/4368455449?check_suite_focus=true
I confirmed the problem doesn't occur with MLflow v1.21.0.
https://github.com/optuna/optuna/runs/4368582442?check_suite_focus=true
So, as a tentative patch, I introduce the version constraint.
Description of the changes