Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doctest to follow the latest MLflow #3136

Closed
himkt opened this issue Nov 30, 2021 · 1 comment 路 Fixed by #3170
Closed

Update doctest to follow the latest MLflow #3136

himkt opened this issue Nov 30, 2021 · 1 comment 路 Fixed by #3170
Labels
bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. contribution-welcome Issue that welcomes contribution. stale Exempt from stale bot labeling.

Comments

@himkt
Copy link
Member

himkt commented Nov 30, 2021

MLflow released the new version (v1.22.0) 馃帀 and it changed logging format.
The doctest in Optuna depends on the log format of MLflow so it fails with the latest MLflow.
(馃敆 See also the tentative fix in #3135)

Expected behavior

All doctests pass.

Environment

  • Optuna version: 2.10.0
  • Python version: 3.9.6
  • OS: Ubuntu 20.04 (WSL2)
  • (Optional) Other libraries and their versions: MLflow 1.22.0

Error messages, stack traces, or logs

Expected:
    INFO: 'my_other_study' does not exist. Creating a new experiment
Got nothing

https://github.com/optuna/optuna/runs/4368455449?check_suite_focus=true#step:6:6119

Steps to reproduce

  1. Install Optuna
  2. Install the latest version of MLflow (pip install -U mlflow)
  3. Run doctest

Reproducible examples (optional)

None (see doctest)

optuna/optuna/integration/mlflow.py

Line 69 in 51b5483

INFO: 'my_study' does not exist. Creating a new experiment

Additional context (optional)
@himkt himkt added the bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. label Nov 30, 2021
@himkt himkt mentioned this issue Nov 30, 2021
Merged
@nzw0301 nzw0301 added the contribution-welcome Issue that welcomes contribution. label Dec 2, 2021
@github-actions
Copy link
Contributor

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Dec 16, 2021
@himkt himkt mentioned this issue Dec 17, 2021
Merged
@nzw0301 nzw0301 linked a pull request Dec 18, 2021 that will close this issue
Remove testoutput from doctest of mlflow integration #3170
Merged
@hvy hvy closed this as completed in #3170 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. contribution-welcome Issue that welcomes contribution. stale Exempt from stale bot labeling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove testoutput from doctest of mlflow integration himkt/optuna
2 participants
@himkt @nzw0301