New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Python Dev Dependencies to Virtual Environment #15602
Conversation
Rename it to `install_python_prod_dependencies.py` to make clear that this script installs production dependencies.
Hi @U8NWXD, can you complete the following:
|
Hi @U8NWXD, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks! |
Hi @U8NWXD, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
Hi @U8NWXD, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
Hi @U8NWXD, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @U8NWXD, can you complete the following:
|
@seanlip I've addressed your comments. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unassigning @vojtechjelinek since they have already approved the PR. |
@seanlip PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @U8NWXD! LGTM, just found one typo. Thanks for removing all the import path messiness!
Hi @U8NWXD, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
* Update third party lib docs for oppia/oppia#15602 * Remove lingering reference to regenerate_requirements.py
Overview
oppia_tools
, this PR changes our installation code to install them to the user's virtual environment. This lets us pin our transitive dev dependency versions using arequirements_dev.txt
file much like we do with arequirements.txt
file for our production python dependencies.Essential Checklist
Proof that changes are correct
I have verified that this PR works correctly by confirming that installing Oppia from scratch works macOS, and I have worked with vojtechjelinek and kevintab95 to test on Linux.
PR Pointers