Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #50: Update third party lib docs for oppia/oppia#15602 #79

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

U8NWXD
Copy link
Member

@U8NWXD U8NWXD commented Jan 11, 2023

Fixes #50 by updating the guide on third-party dependencies to reflect changes in oppia/oppia#15602.

@U8NWXD U8NWXD requested a review from gp201 January 11, 2023 02:53
@gp201
Copy link
Member

gp201 commented Jan 12, 2023

Can you make this chart using mermaid? #81

@U8NWXD
Copy link
Member Author

U8NWXD commented Jan 12, 2023

Probably, but since this is fixing a high-priority issue (the docs for adding a new library are currently wrong), can we make the move to mermaid later? I don't have time to read up on mermaid at the moment

@U8NWXD U8NWXD assigned gp201 and unassigned U8NWXD Jan 12, 2023
Copy link
Member

@gp201 gp201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gp201 gp201 merged commit 468da96 into oppia:develop Jan 12, 2023
@U8NWXD U8NWXD deleted the update-python-dev-dependency-guide branch January 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a backend library
2 participants