Fix bz 1688647 envvar subsitution in curator config files #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
josefkarasek
force-pushed
the
bz1688647-curator-config
branch
from
8a40bb9
to
40bc665
Compare
|
@richm it looks like pyyaml 3.12 is the latest&stable pyyaml we have in rpm. |
jcantrill
reviewed
Mar 22, 2019
josefkarasek
force-pushed
the
bz1688647-curator-config
branch
from
40bc665
to
e8d3457
Compare
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
jcantrill
approved these changes
Mar 28, 2019
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
josefkarasek
force-pushed
the
bz1688647-curator-config
branch
from
e8d3457
to
becc6dd
Compare
|
/retest |
|
/hold I'm struggling with building the rhel dockerfile |
openshift-ci-robot
added
the
do-not-merge/hold
PyYaml 5.1 regression doesnt resolve envvars in configuration files Fix bz 1688647 This isn't a bug fix per se, as rhel image was never affected. Rhel image uses pyyaml 3.10. Only centos image was affected, because python deps are installed via pip.
josefkarasek
force-pushed
the
bz1688647-curator-config
branch
from
becc6dd
to
748cb60
Compare
|
/hold cancel |
|
/retest |
1 similar comment
|
/retest |
|
/test full-integ-aws |
6 similar comments
|
/test full-integ-aws |
|
/test full-integ-aws |
|
/test full-integ-aws |
|
/test full-integ-aws |
|
/test full-integ-aws |
|
/test full-integ-aws |
richm
added
the
approved
|
/retest |
19 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/test full-integ-aws |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
josefkarasek
pushed a commit
to josefkarasek/origin-aggregated-logging
that referenced
this pull request
May 2, 2019
Link github.com/openshift/pull/1568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix envvar subsitution in config files
PyYaml 5.1 regression doesnt resolve envvars in configuration files
Fix bz 1688647
This isn't a bug fix per se, as rhel image was never affected.
Rhel image uses pyyaml 3.10.
Only centos image was affected, because python deps are installed
via pip.
See elastic/curator#1368
Ref https://bugzilla.redhat.com/show_bug.cgi?id=1688647