Do not install pyyaml 5.1

[Reamer]

Hi,

I build my images frequently and I get following error, with the new pyyaml 5.1 version.

019-04-15 01:30:08,330 INFO	Found curator configuration in [/etc/curator/settings/config.yaml]
2019-04-15 01:30:08,336 INFO	Converting config file.
/usr/lib/python2.7/site-packages/curator/utils.py:53: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  cfg = yaml.load(raw)
No handlers could be found for logger "curator.validators.SchemaCheck"
Traceback (most recent call last):
  File "/usr/bin/curator", line 9, in <module>
    load_entry_point('elasticsearch-curator==5.2.0', 'console_scripts', 'curator')()
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib64/python2.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/curator/cli.py", line 211, in cli
    run(config, action_file, dry_run)
  File "/usr/lib/python2.7/site-packages/curator/cli.py", line 106, in run
    client_args = process_config(config)
  File "/usr/lib/python2.7/site-packages/curator/config_utils.py", line 45, in process_config
    config = test_config(yaml_file)
  File "/usr/lib/python2.7/site-packages/curator/config_utils.py", line 19, in test_config
    'Client Configuration', 'full configuration dictionary').result()
  File "/usr/lib/python2.7/site-packages/curator/validators/schemacheck.py", line 68, in result
    self.test_what, self.location, self.badvalue, self.error)
curator.exceptions.ConfigurationError: Configuration: Client Configuration: Location: full configuration dictionary: Bad Value: "{'certificate': '${ES_CA}', 'client_cert': '${ES_CLIENT_CERT}', 'hosts': ['${ES_HOST}'], 'timeout': '${CURATOR_TIMEOUT}', 'use_ssl': True, 'master_only': False, 'port': '${ES_PORT}', 'ssl_no_validate': False, 'client_key': '${ES_CLIENT_KEY}'}", not a valid value for dictionary value @ data['client']['port']. Check configuration file.

It's because of following deprecation https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

For me it's not really clear, why we pin curator to version 5.2. I think at some point curator will fix this. See elastic/curator#1368. It seems curator waits for pyyaml 5.2 elastic/curator#1368 (comment)

[openshift-ci-robot]

Hi @Reamer. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Reamer]

I saw the fix #1568 on master. Can we merge this also in release-3.11?

[jcantrill]

/ok-to-test

[jcantrill]

For me it's not really clear, why we pin curator to version 5.2. I think at some point curator will fix this. See elastic/curator#1368. It seems curator waits for pyyaml 5.2 elastic/curator#1368 (comment)

Curator was pinned to 5.2 because last attempt to bump to the latest version caused our production builds to fail. I'm placing this on hold for now. @josefkarasek are you able to confirm if we can support this PR downstream?

[jcantrill]

/hold

[openshift-ci-robot]

@Reamer: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/json-file	73c4866	link	/test json-file
ci/openshift-jenkins/logging	73c4866	link	/test logging

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[josefkarasek]

@Reamer I pinned it to 3.12 as that's what we have downstream (RHEL based dockerfile).

/pull/1620

Are you alright with it?

[Reamer]

Hi @josefkarasek,
that's absolutely fine. Thanks.