Commits on Jun 8, 2021

1. Fix clusterdeployment tests for DeepEquals …

   TL;DR: When comparing objects coming back from kube, things like
   ResourceVersion should be ignored (unless asserting that the object has
   not changed on the server, in which case comparing *only*
   ResourceVersion should suffice).
   
   We had a couple of tests that were using DeepEquals to compare an object
   from the (fake) kube server to one we constructed locally. The
   ResourceVersion returned by the fake server [changed in
   controller-runtime
   0.8.0](kubernetes-sigs/controller-runtime#1306)
   which broke tests. We [worked
   around](openshift@c7d6052)
   that; but the Right Thing To Do™ is to make the comparison ignore
   ResourceVersion entirely. It is thusly done via this commit.

   

   2uasimojo committed Jun 8, 2021
   Copy the full SHA

   759548b View commit details

   Browse the repository at this point in the history