Fix clusterdeployment tests for DeepEquals #1410
Merged
+35
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
TL;DR: When comparing objects coming back from kube, things like ResourceVersion should be ignored (unless asserting that the object has not changed on the server, in which case comparing *only* ResourceVersion should suffice). We had a couple of tests that were using DeepEquals to compare an object from the (fake) kube server to one we constructed locally. The ResourceVersion returned by the fake server [changed in controller-runtime 0.8.0](kubernetes-sigs/controller-runtime#1306) which broke tests. We [worked around](openshift@c7d6052) that; but the Right Thing To Do™ is to make the comparison ignore ResourceVersion entirely. It is thusly done via this commit.
|
/assign @dgoodwin |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: When comparing objects coming back from kube, things like ResourceVersion should be ignored (unless asserting that the object has not changed on the server, in which case comparing only ResourceVersion should suffice).
We had a couple of tests that were using DeepEquals to compare an object from the (fake) kube server to one we constructed locally. The ResourceVersion returned by the fake server changed in controller-runtime 0.8.0 which broke tests. We worked around that; but the Right Thing To Do™ is to make the comparison ignore ResourceVersion entirely. It is thusly done via this commit.