New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-2770: optimize fluent conf for throughput #1563
LOG-2770: optimize fluent conf for throughput #1563
Conversation
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
log ${record['err'] || record['msg'] || record['MESSAGE'] || record['log']} | ||
</record> | ||
remove_keys req,res,msg,name,level,v,pid,err | ||
json_fields 'message' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously was 'MESSAGE' in upper case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comes from 3.11 where we were pulling container logs using the journal driver. It is no longer relevant since we only pull container logs and I have changed the group capture parameters: https://github.com/openshift/cluster-logging-operator/pull/1563/files#diff-cdd5a7217e8d3eeb415a8f7f720e09303a82c2f9225ee7484d8bdabc11901f1eR148
@@ -367,7 +295,7 @@ const ConcatLines string = ` | |||
{{define "concatLines" -}} | |||
<filter kubernetes.**> | |||
@type concat | |||
key log | |||
key message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for my understanding, this changing related to the optimize data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not relate to optimization other then I made modifications to the incoming parsing expression and have removed and modified a number of filter configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Timestamp: time.Time{}, | ||
Message: "*", | ||
LogType: "application", | ||
Level: "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we remove ViaqIndexName
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is only needed for Elasticsearch so I removed it from ingress and moved it to the ES blocks of configuration.
/lgtm |
@jcantrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
This PR:
Links
based on rudamentary testing of viaq optimizations which enable only features that are being used:
These changes remove much of the fluent viaq design that predates the use of CRIO where there was no standard incoming record format.
Additionally, the improvemets to the kubernetes_metadata plugin are mostly realized by no longer serializing and loading the meta attached to each record