Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency eslint to v8 #3507

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency eslint to v8 #3507

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 20, 2021 •
edited

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 7.32.0 -> 8.1.0 age adoption passing confidence

Release Notes

eslint/eslint

v8.1.0

Compare Source

v8.0.1

Compare Source

v8.0.0

Compare Source

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/eslint-8.x branch 13 times, most recently from ec90c80 to 9952517 Compare October 26, 2021 06:29
@edalex-ian
Copy link
Member

@edalex-yinzi could you please have a look at this. First up, it looks like various plugins need to be upgraded such as those in PR #3509 and #3519 - but there could be more.

@renovate renovate bot force-pushed the renovate/eslint-8.x branch 8 times, most recently from 0217efb to ee8ebf4 Compare October 31, 2021 23:49
@edalex-yinzi
Copy link
Contributor

edalex-yinzi commented Nov 1, 2021 •
edited

According to the confilts info, for oEQ in order to upgrade eslint 8 these deps should also be upgraded to the following version:

"@typescript-eslint/eslint-plugin": "5.2.0",
"@typescript-eslint/parser": "5.2.0",
"eslint-plugin-flowtype": "8.0.3",
"eslint-plugin-jest": "25.2.2",
"eslint-plugin-react-hooks": "4.2.1-alpha-f6abf4b40-20211020"

Unfortunately, after upgrading these deps, still got some issues:

  1. Seems eslint-config-react-app:6.0.0 is not support eslint 8. Got deps conflict error after trying to upgrade eslint 8 through npm upgrade command. And this issue also mentioned eslint-config-react-app is not compatible with eslint 8.
  2. "babel-eslint": "10.1.0" is deprecated I don't think it can support eslint 8 because we get some Parsing error: require() of ES Module from this. If follow this instructions using @babel/eslint-parser instead, still get lots of errors after some tries.
  3. This issues indicates that eslint-plugin-react is still in the process of supporting eslint 8. Not sure if it's one of the reason caused failure in upgrade but we do have this deps.

@edalex-ian
Copy link
Member

Alright, thanks @edalex-yinzi . I'll close this for now until the other deps are also ready. 👍

@edalex-ian edalex-ian closed this Nov 1, 2021
@edalex-ian edalex-ian deleted the renovate/eslint-8.x branch November 1, 2021 03:00
@renovate
Copy link
Contributor Author

renovate bot commented Nov 1, 2021 •
edited

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 8.x releases. However, if you upgrade to 8.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

This was referenced Nov 1, 2021
Closed
Closed
This was referenced Jan 4, 2022
Closed
Closed
@edalex-yinzi edalex-yinzi mentioned this pull request Jan 4, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edalex-yinzi edalex-yinzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edalex-ian @edalex-yinzi @renovate-bot