Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency eslint to v8 #3674

Merged
merged 3 commits into from Jan 4, 2022

Conversation

edalex-yinzi
Copy link
Contributor

@edalex-yinzi edalex-yinzi commented Jan 4, 2022

Checklist
Description of change

This is a fix PR for upgrading eslint to v8, see previous attempts in: #3673 #3507
All the dependencies related/dependent on eslint v8 are also included in this PR:

@edalex-ian
Copy link
Member

Interesting... I note the package-lock is updated in the react-front-end even though you didn't touch the package.json in there; however it's not updated in oeq-rest-ts-api event though you did update the package.json in there... I think things are slightly muddled at the package-lock level.

@PenghaiZhang
Copy link
Contributor

Interesting... I note the package-lock is updated in the react-front-end even though you didn't touch the package.json in there; however it's not updated in oeq-rest-ts-api event though you did update the package.json in there... I think things are slightly muddled at the package-lock level.

I expect to see a package-lock update in oeq-rest-ts-api, not in react-front-end .

@edalex-ian
Copy link
Member

Exactly, for this update I'd expect to see exactly four files updated:

  • package.json
  • package-lock.json
  • oeq-ts-rest-api/package.json
  • oeq-ts-rest-api/package-lock.json

(And that's because oeq-ts-rest-api looks after it's own linting for the day it becomes a stand-alone module.)

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There we go, now it's looking good. Let's hope it's all green. 😉

@edalex-ian
Copy link
Member

Doesn't come into play for the functional tests, already done it's job, so I'll merge now. 😉

@edalex-ian edalex-ian merged commit 70fc103 into openequella:develop Jan 4, 2022
@edalex-yinzi edalex-yinzi deleted the upgrade/eslint_8 branch January 4, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants