Update Go matrix in CI for Go v1.22 #1166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
sudo-bmitch,
sajayantony,
tianon,
vbatts and
cyphar
as code owners
This change adds Go v1.22 to CI matrix and removes Go v1.19 and v1.20 because they will no longer receive updates. Additionally it removes the golangci-lint versions for Go v1.19 and v1.20 in Makefile. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
update-go-in-ci
branch
from
1a2b9a5
to
de5404a
Compare
tianon
reviewed
Feb 17, 2024
| @@ -9,7 +9,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go: ['1.19', '1.20', '1.21'] | |||
| go: ['1.21', '1.22'] | |||
There was a problem hiding this comment.
IMO we should add back 1.18 (matching go.mod), but I don't feel strongly enough to block if other maintainers disagree
I recall there's a way we could have setup-go read go.mod directly too, if we wanted to get fancy, but I don't think that's strictly necessary either
sudo-bmitch
requested changes
Feb 17, 2024
Comment on lines
-123
to
-124
| go1.18.*) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.47.3;; \ | ||
| go1.19.*) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1;; \ |
There was a problem hiding this comment.
These should be kept to support anyone testing with an older version of Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
N/A
Description:
This change updates the Go matrix in CI to add Go v1.22 and drops v1.19 and v1.20 as they would stop receiving updates.
Additional resources: