Update Go versions in release scripts #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
sajayantony,
tianon,
vbatts and
cyphar
as code owners
tianon
approved these changes
Feb 19, 2024
austinvazquez
approved these changes
Feb 22, 2024
sajayantony
approved these changes
Apr 25, 2024
rchincha
reviewed
Apr 25, 2024
| @@ -9,7 +9,11 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go: ['1.19', '1.20', '1.21'] | |||
| # current Go releases plus the version in the go.mod are tested | |||
| go: ['1.18', '1.21', '1.22'] | |||
There was a problem hiding this comment.
This list has changed? should be 1.22 and two versions lower?
There was a problem hiding this comment.
It used to be two versions lower and I broke with that to have the two stable releases and the version that's in our go.mod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1166 and fixes a remaining item from #1165. It supports current Go releases and 1.18, upgrades the upload-artifact workflow, but only runs that workflow for the latest Go version.