Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions packages to resolve warnings in CI #1165

Merged

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Feb 11, 2024

Issue:

N/A

Description:

This change updates actions/checkout to v4 and actions/setup-go to v5 to resolve NodeJS 16 deprecation warnings in CI.

Before:

image

Additional References:

@austinvazquez
Copy link
Contributor Author

It looks like CI is failing due to linter version not being pinned for 1.20. Will see if I can open another PR to address.

@austinvazquez
Copy link
Contributor Author

Opened #1167 to resolve CI issues.

@tianon
Copy link
Member

tianon commented Feb 17, 2024

I guess this is ready for a rebase? 👀

@austinvazquez
Copy link
Contributor Author

Hmm, the issue with actions/upload-artifacts@v4 seems to stem from the breaking change documented in https://github.com/actions/upload-artifact:

  1. Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

I could try 'overwrite: true' however that also means the documentation could be created by different workflow runs. e.g. Go 1.19, 1.20, 1.21. Perhaps it would be best to revert this change for now and handle separately.

This change updates actions/checkout to v4 and actions/setup-go to v5 to
resolve NodeJS 16 deprecation warnings in CI.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@sudo-bmitch
Copy link
Contributor

  1. Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

I can push a separate fix for that.

Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon tianon merged commit f5f8701 into opencontainers:main Feb 19, 2024
4 checks passed
@austinvazquez austinvazquez deleted the update-github-actions-packages branch February 19, 2024 21:18
JefriReynaldi

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants