Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sequelize to the latest version #7142

Merged
merged 2 commits into from Feb 25, 2022
Merged

chore: update sequelize to the latest version #7142

merged 2 commits into from Feb 25, 2022

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Feb 8, 2022

Resolve opencollective/opencollective#5215

There was also an unknown bug in sequelize v6.16.0, I created a PR to point it out and fix the issue in the sequelize repository itself - sequelize/sequelize#14071 sequelize/sequelize#14071 (comment)

The change was accepted and a new patch version v6.16.1 is now released.

There was another unknown regression, I reported it in sequelize/sequelize#14129

The issue was fixed and a new patch version v6.16.3 is now released.

@snitin315 snitin315 force-pushed the update-sequalize branch 2 times, most recently from 84a4d92 to 6187302 Compare February 9, 2022 09:48
@snitin315 snitin315 marked this pull request as ready for review February 9, 2022 10:08
@snitin315 snitin315 requested a review from znarf February 9, 2022 10:17
Copy link

@Vic23M Vic23M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fusión de cambios

Copy link
Member

@znarf znarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! That looks good.

server/models/PaypalPlan.ts Outdated Show resolved Hide resolved
@znarf znarf self-requested a review February 16, 2022 07:56
Copy link
Member

@znarf znarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change required.

@znarf
Copy link
Member

znarf commented Feb 22, 2022

Thank you for the follow up @snitin315, this looks promising.

@znarf znarf changed the title chore: update sequalize to the latest version chore: update sequelize to the latest version Feb 23, 2022
@snitin315
Copy link
Member Author

@znarf I have updated the dependency with the latest patch release for the blocking issue - sequelize/sequelize#14129

All good now. We can safely merge.

@znarf znarf merged commit 828b1ed into main Feb 25, 2022
@znarf znarf deleted the update-sequalize branch February 25, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sequelize to 6.16
4 participants