Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequelize to 6.16 #5215

Closed
znarf opened this issue Feb 8, 2022 · 5 comments · Fixed by opencollective/opencollective-api#7142
Closed

Update sequelize to 6.16 #5215

znarf opened this issue Feb 8, 2022 · 5 comments · Fixed by opencollective/opencollective-api#7142
Assignees
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) bounty complexity → simple technical-debt Deprecated code to migrate and other necessary refactors $100 minimal or unknown complexity bounty (v2)

Comments

@znarf
Copy link
Member

znarf commented Feb 8, 2022

In our API repository, we're using Sequelize version 6.13.

The latest version is 6.16 but the update is currently blocked because of breaking changes (typescript).
opencollective/opencollective-api#7072

We would like to upgrade to the latest version and make sure our test suite pass properly on GitHub actions.

@znarf znarf added complexity → simple api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) technical-debt Deprecated code to migrate and other necessary refactors $100 minimal or unknown complexity bounty (v2) bounty labels Feb 8, 2022
@znarf
Copy link
Member Author

znarf commented Feb 8, 2022

🎁 💸 A $100 bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with $100 when the Pull Request is reviewed, accepted and merged.

➡️ More info

@znarf
Copy link
Member Author

znarf commented Feb 25, 2022

🏆 This issue was completed by @snitin315

To claim the bounty, as a recurring contributor, please simply add it to your next invoice to Open Collective Engineering https://opencollective.com/engineering/expenses/new Please make sure to mention the ticket number in the invoice and in the expense title.

@znarf znarf closed this as completed Feb 25, 2022
@ephys
Copy link

ephys commented Mar 18, 2022

I'm not speaking for the other maintainers, just for myself, and I know it's too late but I think these funds would have been better allocated by donating them to the Sequelize development fund as we're the one that fixed the issue.
I won't raise hell over it, after all we're also the ones that introduced the issue in the first place, but I felt the need to speak up as I felt a bit cheated to not have been made aware that there was a bounty related to fixing this issue.

@znarf
Copy link
Member Author

znarf commented Mar 18, 2022

@ephys I understand the feeling.

I'm personally convinced that @snitin315 deserves the bounty here. As a trusted contributor, he investigated it, created an issue in your repository and followed up. The bounty here was a generic one, figuring what what's wrong with latest Sequelize update, not precisely asking to fix something specific on Sequelize side.

I'm also convinced that the Sequelize project deserves something for the help here. And also another recent one here: opencollective/opencollective-api#7214 But more generally to sustain your work, which is a critical component of our API project.

We'll immediately donate $100 to match this bounty. Also, I'm happy to tell you that in the next days, we will start a Fund to give back to OSS projects we use, this is something we planned in our last team meeting in January. Sequelize will definitely be a natural recipient for it.

@ephys
Copy link

ephys commented Mar 18, 2022

@znarf You're right, it would be unfair to take the bounty away from @snitin315 who has been a great person to collaborate with the whole time. My comment also did not take into account the work that went into opencollective/opencollective-api#7142 before it reached us

I'm really grateful and pleasantly surprised by the bounty match, as well as this great news. Thank you, it means a lot to us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) bounty complexity → simple technical-debt Deprecated code to migrate and other necessary refactors $100 minimal or unknown complexity bounty (v2)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants