-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docfx CI #4026
Fix docfx CI #4026
Conversation
It seems like the action is still failing: https://github.com/open-telemetry/opentelemetry-specification/actions/runs/8899804175/job/24439957035?pr=4026 Is that the workflow this is intended to address? |
That seems to be a different issue. |
Thanks for tackling this @reyang would be great to get this going again. ☮️ |
The latest error seems to be coming from the tool itself which I haven't got time to follow up. https://github.com/open-telemetry/opentelemetry-specification/actions/runs/8900019522/job/24440633172?pr=4026 I think we can make it optional for now to unblock the PRs. |
FYI @open-telemetry/technical-committee @open-telemetry/specs-approvers I've removed "Checks / docfx (pull_request)" from the Required CI for now. |
DocFx v3 is no longer available and not intended to be used externally. The feature it provided that we don't have from other tooling is cross-file anchor reference check, see open-telemetry/semantic-conventions#1009 for the details. It seems there is no popular (or even not popular) replacement for it. DocFx v2 only check anchors within the same file which markdownlint does as well. Related: open-telemetry/semantic-conventions#1008 Closes #4026.
Unblock CI, seems related to some external changes on DocFx https://github.com/open-telemetry/opentelemetry-specification/actions/runs/8897991631/job/24439658872?pr=4002.