Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docfx #4036

Merged
merged 4 commits into from
May 7, 2024
Merged

Remove docfx #4036

merged 4 commits into from
May 7, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented May 7, 2024

DocFx v3 is no longer available and not intended to be used externally.

The feature it provided that we don't have from other tooling is cross-file anchor reference check, see open-telemetry/semantic-conventions#1009 for the details. It seems there is no popular (or even not popular) replacement for it.

DocFx v2 only check anchors within the same file which markdownlint does as well.

Related: open-telemetry/semantic-conventions#1008

Closes #4026.

Changes

This PR removes docfx since v2 does not provide additional value. We'll need to find a different solution for relative anchor checks.

@lmolkova lmolkova requested review from a team as code owners May 7, 2024 01:28
@carlosalberto
Copy link
Contributor

Let's give a heads up to people on today's Spec call, and otherwise let's merge this fast.

@arminru arminru requested a review from reyang May 7, 2024 15:44
@carlosalberto carlosalberto merged commit 2d6456a into open-telemetry:main May 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants