Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix tests for sidekiq to support inline lua changes #1011

Merged
merged 2 commits into from Nov 9, 2021
Merged

chore: fix tests for sidekiq to support inline lua changes #1011

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1ea9c0
chore: fix tests for sidekiq to support inline lua changes to redis c…
ericmustin Nov 8, 2021
1b0a7f9
chore: add additional sidekiq appraisal
ericmustin Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion instrumentation/sidekiq/test/opentelemetry/instrumentation/sidekiq/patches/poller_test.rb
View file
Open in desktop
Expand Up @@ -46,7 +46,8 @@
poller.enqueue
span_names = spans.map(&:name)
_(span_names).must_include('Sidekiq::Scheduled::Poller#enqueue')
_(span_names).must_include('ZRANGEBYSCORE')
# Inline Lua uses a different redis client method in 6.3+ https://github.com/mperham/sidekiq/pull/5044
_(span_names).must_include('ZRANGEBYSCORE') if Gem.loaded_specs['sidekiq'].version < Gem::Version.new('6.3')
end

describe 'when peer_service config is set' do
Expand Down