chore: fix tests for sidekiq to support inline lua changes #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmustin
requested review from
ahayworth,
arielvalentin,
dazuma,
fbogsany,
mwear and
robertlaurin
as code owners
|
Do we expect to support 6.3? Should there be a separate appraisal for it? |
arielvalentin
approved these changes
Nov 8, 2021
|
@arielvalentin i think that makes sense, updated, good catch |
arielvalentin
approved these changes
Nov 9, 2021
mwear
approved these changes
Nov 9, 2021
schanjr
added a commit
to schanjr/opentelemetry-ruby
that referenced
this pull request
Nov 20, 2021
* initial code complete * chore: fix tests for sidekiq to support inline lua changes (open-telemetry#1011) * chore: fix tests for sidekiq to support inline lua changes to redis calls * chore: add additional sidekiq appraisal * feat: add dalli obfuscation for db_statement (open-telemetry#1013) * feat: add dalli obfuscation for db_statement * chore: linting * Link to website spec pages (open-telemetry#1018) Co-authored-by: Matthew Wear <matthew.wear@gmail.com> * Feat: Add custom getters to common (open-telemetry#1006) Co-authored-by: Matthew Wear <matthew.wear@gmail.com> Co-authored-by: Eric Mustin <eric.mustin@shopify.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Co-authored-by: Matthew Wear <matthew.wear@gmail.com> Co-authored-by: Robert <robertlaurin@users.noreply.github.com>
schanjr
added a commit
to schanjr/opentelemetry-ruby
that referenced
this pull request
Nov 20, 2021
* initial code complete * chore: fix tests for sidekiq to support inline lua changes (open-telemetry#1011) * chore: fix tests for sidekiq to support inline lua changes to redis calls * chore: add additional sidekiq appraisal * feat: add dalli obfuscation for db_statement (open-telemetry#1013) * feat: add dalli obfuscation for db_statement * chore: linting * Link to website spec pages (open-telemetry#1018) Co-authored-by: Matthew Wear <matthew.wear@gmail.com> * Feat: Add custom getters to common (open-telemetry#1006) Co-authored-by: Matthew Wear <matthew.wear@gmail.com> Co-authored-by: Eric Mustin <eric.mustin@shopify.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Co-authored-by: Matthew Wear <matthew.wear@gmail.com> Co-authored-by: Robert <robertlaurin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sidekiq cut a 6.3 release over the weekend, which has some fancy new and improved inline Lua sidekiq/sidekiq#5044. While slick, it also happens to use a slightly different redis client method that ends up breaking some of our test assumptions about what gets traced in redis from our sidekiq poller instrumentation. Our CI is now failing as a result(failed run example here: https://github.com/open-telemetry/opentelemetry-ruby/runs/4144038824?check_suite_focus=true).
This PR updates the sidekiq instrumentation test suite to only expect that poller redis instrumentation when
sidekiq < 6.3x.Not exactly the prettiest solution but ought to work? long term i think further evidence that a canary build or some pessimistic version constraints can help us avoid this sort of brittleness open-telemetry/opentelemetry-ruby-contrib#373