Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing opentelemetry-extension-aws artifact #4945

Merged
merged 2 commits into from Nov 17, 2022

Conversation

jack-berg
Copy link
Member

Resolves #4831.

This artifact already exists in opentelemetry-java-contrib and has gone through a minor release with deprecation. This stops new publications of opentelemetry-extension-aws, but keeps the last published version referenced in opentelemetry-bom.

@jack-berg jack-berg requested a review from a team as a code owner November 12, 2022 00:21
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 91.03% // Head: 91.04% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e6c3aad) compared to base (6c7637b).
Patch has no changes to coverable lines.

❗ Current head e6c3aad differs from pull request most recent head f975b9b. Consider uploading reports for the commit f975b9b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4945      +/-   ##
============================================
+ Coverage     91.03%   91.04%   +0.01%     
+ Complexity     4841     4804      -37     
============================================
  Files           546      544       -2     
  Lines         14447    14297     -150     
  Branches       1395     1367      -28     
============================================
- Hits          13152    13017     -135     
+ Misses          891      884       -7     
+ Partials        404      396       -8     
Impacted Files Coverage Δ
...ava/io/opentelemetry/opentracingshim/SpanShim.java 87.61% <0.00%> (-0.89%) ⬇️
...opentelemetry/opentracingshim/SpanBuilderShim.java 88.28% <0.00%> (-0.87%) ⬇️
.../opentelemetry/sdk/internal/ComponentRegistry.java 100.00% <0.00%> (ø)
...emconv/resource/attributes/ResourceAttributes.java 100.00% <0.00%> (ø)
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 08e19e3 into open-telemetry:main Nov 17, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
sdelamo added a commit to micronaut-projects/micronaut-tracing that referenced this pull request Apr 15, 2024
It replaces :

```
io.opentelemetry:opentelemetry-sdk-extension-aws
```

with:

```
io.opentelemetry.contrib:opentelemetry-aws-resources
```

and:

```
io.opentelemetry.contrib:opentelemetry-aws-xray-propagator
```

see:

open-telemetry/opentelemetry-java#4945
open-telemetry/opentelemetry-java#4831

it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha

> Version 1.34.0 targets the OpenTelemetry SDK 1.34.0.

As we are in 1.36.0 I think this is the correct version to use for it.
sdelamo added a commit to micronaut-projects/micronaut-tracing that referenced this pull request Apr 15, 2024
* test: adds a test-suite-xray module

This adds a test-suite-xray module to verify the following dependencies are resolvables without specifying the version:

io.opentelemetry:opentelemetry-exporter-otlp
io.opentelemetry:opentelemetry-extension-aws
io.opentelemetry.instrumentation:opentelemetry-aws-sdk-2.2

* bug: replace opentelemetry-sdk-extension-aws mentions

It replaces :

```
io.opentelemetry:opentelemetry-sdk-extension-aws
```

with:

```
io.opentelemetry.contrib:opentelemetry-aws-resources
```

and:

```
io.opentelemetry.contrib:opentelemetry-aws-xray-propagator
```

see:

open-telemetry/opentelemetry-java#4945
open-telemetry/opentelemetry-java#4831

it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha

> Version 1.34.0 targets the OpenTelemetry SDK 1.34.0.

As we are in 1.36.0 I think this is the correct version to use for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move opentelemetry-extension-aws to contrib
3 participants