Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: replace opentelemetry-sdk-extension-aws mentions #541

Merged
merged 2 commits into from Apr 15, 2024
Merged

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Apr 15, 2024

It replaces :

io.opentelemetry:opentelemetry-sdk-extension-aws

with:

io.opentelemetry.contrib:opentelemetry-aws-resources

and:

io.opentelemetry.contrib:opentelemetry-aws-xray-propagator

see:

open-telemetry/opentelemetry-java#4945
open-telemetry/opentelemetry-java#4831

it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha

Version 1.34.0 targets the OpenTelemetry SDK 1.34.0.

As we are in 1.36.0 I think this is the correct version to use for it.

This adds a test-suite-xray module to verify the following dependencies are resolvables without specifying the version:

io.opentelemetry:opentelemetry-exporter-otlp
io.opentelemetry:opentelemetry-extension-aws
io.opentelemetry.instrumentation:opentelemetry-aws-sdk-2.2
It replaces :

```
io.opentelemetry:opentelemetry-sdk-extension-aws
```

with:

```
io.opentelemetry.contrib:opentelemetry-aws-resources
```

and:

```
io.opentelemetry.contrib:opentelemetry-aws-xray-propagator
```

see:

open-telemetry/opentelemetry-java#4945
open-telemetry/opentelemetry-java#4831

it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha

> Version 1.34.0 targets the OpenTelemetry SDK 1.34.0.

As we are in 1.36.0 I think this is the correct version to use for it.
@sdelamo sdelamo requested a review from n0tl3ss April 15, 2024 11:27
@sdelamo sdelamo changed the title Add to bom bug: replace opentelemetry-sdk-extension-aws mentions Apr 15, 2024
@sdelamo sdelamo added type: bug Something isn't working type: docs labels Apr 15, 2024
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sdelamo added a commit to micronaut-projects/micronaut-starter that referenced this pull request Apr 15, 2024
sdelamo added a commit to micronaut-projects/micronaut-starter that referenced this pull request Apr 15, 2024
@sdelamo sdelamo merged commit 3c5035f into 6.5.x Apr 15, 2024
11 checks passed
@sdelamo sdelamo deleted the add-to-bom branch April 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: docs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants