Add deprecation notice for the package. #2313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier for devs to follow in future, adding a deprecated notice with references of where the changes are going will help with uptake of the project
MovieStoreGuy
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
|
This is to help the migration effort made in #2273 |
Codecov Report
@@ Coverage Diff @@
## main #2313 +/- ##
=======================================
- Coverage 72.7% 72.6% -0.1%
=======================================
Files 172 172
Lines 11911 11911
=======================================
- Hits 8662 8655 -7
- Misses 3017 3022 +5
- Partials 232 234 +2
|
MrAlias
requested changes
Oct 21, 2021
|
It looks like the staticchecks are failing. Please upgrade the project to use the replacement of this deprecated package to resolve these failures. |
pellared
approved these changes
Oct 21, 2021
|
@MrAlias , Poop I didn't think it would break some other checks setting the package as deprecated early. I have concerns making the changes all in one pass since it would be a rather large sweeping change, might be hard to review effectively. Gonna suggest that this PR is parked until the work set out #2273 is done. |
|
I'm going to close this for the time being. Please reopen it when it is ready to progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier for devs to follow in future, adding a deprecated
notice with references of where the changes are going will help with
uptake of the project