Moving the exporter into the correct path #2325
Conversation
MovieStoreGuy
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
|
Not sure if you had anything else you wanted to move over to this new package @jmacd |
|
For context my idea for this work is to soft deprecate each interface/method/type as they are moved across and then once all the work is done, then deprecating the package and removing the entries defined as per #2313 |
There was a problem hiding this comment.
Since this would be my first PR for the repo...
Thanks for the contribution!
I am making small commits to assist with #2273
This is greatly appreciated.
Can you please add deprecation to the changelog under a ### Deprecated header.
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
@MrAlias , is the change log needed for all deprecated changes? |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
It is. We try to follow the principles and procedures outlined in https://keepachangelog.com/en/1.0.0/. |
Codecov Report
@@ Coverage Diff @@
## main #2325 +/- ##
=======================================
- Coverage 73.6% 73.6% -0.1%
=======================================
Files 175 175
Lines 12409 12409
=======================================
- Hits 9137 9134 -3
- Misses 3039 3041 +2
- Partials 233 234 +1
|
|
Gotcha, thanks you @MrAlias |
Added deprecated notice for the interface being moved
| @@ -41,6 +41,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - `semconv.NetAttributesFromHTTPRequest()` correctly handles IPv6 addresses. (#2285) | |||
| - The simple span processor shutdown method deterministically returns the exporter error status if it simultaneously finishes when the deadline is reached. (#2290, #2289) | |||
|
|
|||
| ### Deprecated | |||
|
|
|||
| - The `Exporter` defined in `"go.opentelemetry.io/otel/sdk/export/metric"` is now deprecated and moved to `"go.opentelemetry.io/otel/sdk/metric/processor"` (#2273) | |||
There was a problem hiding this comment.
| - The `Exporter` defined in `"go.opentelemetry.io/otel/sdk/export/metric"` is now deprecated and moved to `"go.opentelemetry.io/otel/sdk/metric/processor"` (#2273) | |
| - The `Exporter` defined in `"go.opentelemetry.io/otel/sdk/export/metric"` is now deprecated and moved to `"go.opentelemetry.io/otel/sdk/metric/exporter"` (#2325) |
right?
There was a problem hiding this comment.
Yes, sorry. I thought I can move the three types at once without getting things crossed over. 🤦🏽
Since this would be my first PR for the repo, I am making small commits to assist with #2273