fix: custom attributes are ignored - #5084 #5129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
reviewed
Feb 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5129 +/- ##
=======================================
- Coverage 62.4% 62.3% -0.1%
=======================================
Files 190 189 -1
Lines 11646 11577 -69
=======================================
- Hits 7269 7223 -46
+ Misses 4160 4145 -15
+ Partials 217 209 -8
|
zailic
requested review from
MrAlias,
dashpole,
MadVikingGod,
yurishkuro,
pellared and
hanyuancheung
as code owners
|
@dmathieu - Could you please let me know if there's any changes or information from me in order to move forward with this PR? |
dmathieu
reviewed
Mar 27, 2024
* Implement slog Handler Enabled * Comment MinSeverity field * Run go mod tidy
* Add Version func * Implement the config * Add TestNewHandlerConfiguration * Replace Version func with const
…elemetry#5325) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.2 to 1.57.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.56.2...v1.57.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.8 to 1.27.9 in /instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/example build(deps): bump github.com/aws/aws-sdk-go-v2/service/dynamodb from 1.30.5 to 1.31.0 in /instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/example build(deps): bump github.com/aws/aws-sdk-go from 1.51.3 to 1.51.6 in /detectors/aws/ec2 build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.8 to 1.27.9 in /instrumentation/github.com/aws/aws-lambda-go/otellambda/example build(deps): bump github.com/aws/aws-sdk-go-v2/service/dynamodb from 1.30.5 to 1.31.0 in /instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/test build(deps): bump github.com/aws/aws-sdk-go-v2/service/dynamodb from 1.30.5 to 1.31.0 in /instrumentation/github.com/aws/aws-sdk-go-v2/otelaws
dmathieu
reviewed
Mar 27, 2024
* Add update-all-otel-deps target in Makefile * Update indirect otel dependencies as well
…elemetry#5441) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.57.2 to 1.58.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.57.2...v1.58.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lemetry#5445) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* processors/baggage: add baggage span processor Fixes open-telemetry#5397 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * fix lint issues + dependabot generate Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * apply review feedback Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * more review feedback Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * Update processors/baggage/processor_test.go Co-authored-by: Robert Pająk <pellared@hotmail.com> * lint Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * feedback from review Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * rename baggage -> baggagetrace Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * more fixes Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * docs Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * lint fixes Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * generate Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Damien Mathieu <42@dmathieu.com> * Update CHANGELOG.md * Update processors/baggage/baggagetrace/doc.go * Apply suggestions from code review Co-authored-by: Robert Pająk <pellared@hotmail.com> * Update processors/baggage/baggagetrace/processor.go Co-authored-by: Robert Pająk <pellared@hotmail.com> * Apply suggestions from code review * Update CHANGELOG.md * Update CODEOWNERS Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com> --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Damien Mathieu <42@dmathieu.com> Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com> Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
….3 (open-telemetry#5462) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…elemetry#5465) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n-telemetry#5467) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pen-telemetry#5466) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n-telemetry#5470) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…00308113650-138e5925c53b (open-telemetry#5471) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pen-telemetry#5468) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n-telemetry#5469) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…10331224755-41bb18bfe9da (open-telemetry#5472) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…506185236-b8a5c65736ae (open-telemetry#5476) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0408141607-282e7b5d6b74 (open-telemetry#5473) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-20240221224432-82ca36839d55 (open-telemetry#5474) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…to v0.0.0-20240506185236-b8a5c65736ae (open-telemetry#5477) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n-telemetry#5460) Bumps [go.opentelemetry.io/contrib/bridges/prometheus](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.50.0 to 0.51.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.50.0...zpages/v0.51.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/bridges/prometheus dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…11-f0e62f92d13f (open-telemetry#5478) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n-telemetry#5479) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…en-telemetry#5482) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pen-telemetry#5458) Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.20.0 to 0.21.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.20.0...v0.21.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…y#5486) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2dddb1d0 (open-telemetry#5480) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK... i opened a new PR for #5084 issue, as i shot myself in a foot trying to modify a previous commit that I pushed under another github user.