fix: make possible adding custom attributes to the shipped otelhttp client metrics - #5084 #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
You will need to sign the CLA, add a changelog as well as tests. |
dmathieu
reviewed
Feb 13, 2024
| @@ -48,7 +48,7 @@ type labelerContextKeyType int | |||
|
|
|||
| const lablelerContextKey labelerContextKeyType = 0 | |||
|
|
|||
| func injectLabeler(ctx context.Context, l *Labeler) context.Context { | |||
| func InjectLabeler(ctx context.Context, l *Labeler) context.Context { | |||
There was a problem hiding this comment.
Why does this need to become public?
There was a problem hiding this comment.
Otherwise you cannot inject a Labeler component outside the otelhttp module.(as labelerContextKey is private as well). The given details on #5084 aren't clear enough?
…ry#5081) * dependabot updates Mon Feb 12 15:30:58 UTC 2024 build(deps): bump go.opentelemetry.io/otel/sdk from 1.23.0 to 1.23.1 in /instrumentation/github.com/labstack/echo/otelecho/test build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /instrumentation/github.com/labstack/echo/otelecho/test build(deps): bump go.opentelemetry.io/otel/trace from 1.23.0 to 1.23.1 in /instrumentation/github.com/labstack/echo/otelecho/test build(deps): bump go.opentelemetry.io/otel/trace from 1.23.0 to 1.23.1 in /propagators/b3 build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /propagators/b3 build(deps): bump go.opentelemetry.io/otel/trace from 1.23.0 to 1.23.1 in /instrumentation/github.com/labstack/echo/otelecho build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /instrumentation/github.com/labstack/echo/otelecho build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /instrumentation/github.com/aws/aws-lambda-go/otellambda/example build(deps): bump go.opentelemetry.io/otel/trace from 1.23.0 to 1.23.1 in /propagators/ot build(deps): bump go.opentelemetry.io/otel/exporters/stdout/stdouttrace from 1.23.0 to 1.23.1 in /instrumentation/github.com/aws/aws-lambda-go/otellambda/example build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /propagators/ot build(deps): bump go.opentelemetry.io/otel/sdk from 1.23.0 to 1.23.1 in /instrumentation/github.com/aws/aws-lambda-go/otellambda/example build(deps): bump github.com/golangci/golangci-lint from 1.55.2 to 1.56.1 in /tools build(deps): bump golang.org/x/vuln from 1.0.3 to 1.0.4 in /tools build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /detectors/aws/ecs build(deps): bump go.opentelemetry.io/otel/sdk from 1.23.0 to 1.23.1 in /detectors/aws/ecs build(deps): bump go.opentelemetry.io/otel/trace from 1.23.0 to 1.23.1 in /instrumentation/github.com/aws/aws-lambda-go/otellambda build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /instrumentation/github.com/aws/aws-lambda-go/otellambda build(deps): bump go.opentelemetry.io/otel/sdk from 1.23.0 to 1.23.1 in /instrumentation/host/example build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /instrumentation/host/example build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /samplers/aws/xray build(deps): bump go.opentelemetry.io/otel/exporters/stdout/stdoutmetric from 1.23.0 to 1.23.1 in /instrumentation/host/example build(deps): bump go.opentelemetry.io/otel/sdk from 1.23.0 to 1.23.1 in /samplers/aws/xray build(deps): bump go.opentelemetry.io/otel/sdk/metric from 1.23.0 to 1.23.1 in /instrumentation/host/example build(deps): bump go.opentelemetry.io/otel/trace from 1.23.0 to 1.23.1 in /samplers/aws/xray build(deps): bump go.opentelemetry.io/otel/sdk from 1.23.0 to 1.23.1 in /detectors/aws/lambda build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /detectors/aws/lambda build(deps): bump go.opentelemetry.io/otel/sdk from 1.23.0 to 1.23.1 in /detectors/aws/ec2 build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /detectors/aws/ec2 build(deps): bump go.opentelemetry.io/otel from 1.23.0 to 1.23.1 in /instrumentation/runtime * Apply lint fixes --------- Co-authored-by: Tyler Yahn <codingalias@gmail.com>
build(deps): bump github.com/aws/aws-sdk-go from 1.50.10 to 1.50.15 in /detectors/aws/ec2 build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.23.0 to 1.23.1 in /config build(deps): bump golang.org/x/net from 0.20.0 to 0.21.0 in /instrumentation/google.golang.org/grpc/otelgrpc/example build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.23.0 to 1.23.1 in /instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace from 1.23.0 to 1.23.1 in /exporters/autoexport build(deps): bump go.opentelemetry.io/otel/exporters/prometheus from 0.45.1 to 0.45.2 in /exporters/autoexport build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.23.0 to 1.23.1 in /exporters/autoexport build(deps): bump go.opentelemetry.io/otel/bridge/opencensus from 1.23.0 to 1.23.1 in /propagators/opencensus
Bumps golang from 1.21-alpine to 1.22-alpine. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Bumps golang from 1.21-alpine to 1.22-alpine. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Bumps golang from 1.21 to 1.22. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Bumps golang from 1.21-alpine to 1.22-alpine. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
open-telemetry#4964) Bumps golang from 1.21-alpine to 1.22-alpine. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…emetry#4897) * fork a subset of google.golang.org/grpc/interop to otelgrpc --------- Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
zailic
force-pushed
the
bugfix/issue-5084
branch
from
d552aa6
to
1a0432a
Compare
…#5080) * use an atomic.Int64 as bodyWrapper read bytes counter * add changelog entry --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update README * Update changelog * Update CI workflows * Update Dockerfiles * Update changelog entry PR number
|
i will close it in favor of #5129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details on #5084.