Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Go 1.17 #2785

Merged
merged 5 commits into from Sep 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Expand Up @@ -109,7 +109,7 @@ jobs:
compatibility-test:
strategy:
matrix:
go-version: [1.19, 1.18, 1.17]
go-version: [1.19, 1.18]
os: [ubuntu-latest, macos-latest, windows-latest]
# GitHub Actions does not support arm* architectures on default
# runners. It is possible to acomplish this with a self-hosted runner
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -8,6 +8,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]

### Removed

- Drop support for Go 1.17.
The project currently only supports Go 1.18 and above. (#2785)

## [0.36.0]

### Changed
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -119,7 +119,7 @@ go-mod-tidy/%: DIR=$*
go-mod-tidy/%:
@echo "$(GO) mod tidy in $(DIR)" \
&& cd $(DIR) \
&& $(GO) mod tidy -compat=1.17
&& $(GO) mod tidy -compat=1.18

.PHONY: misspell
misspell: | $(MISSPELL)
Expand Down
5 changes: 0 additions & 5 deletions README.md
Expand Up @@ -46,19 +46,14 @@ This project is tested on the following systems.
| ------- | ---------- | ------------ |
| Ubuntu | 1.19 | amd64 |
| Ubuntu | 1.18 | amd64 |
| Ubuntu | 1.17 | amd64 |
| Ubuntu | 1.19 | 386 |
| Ubuntu | 1.18 | 386 |
| Ubuntu | 1.17 | 386 |
| MacOS | 1.19 | amd64 |
| MacOS | 1.18 | amd64 |
| MacOS | 1.17 | amd64 |
| Windows | 1.19 | amd64 |
| Windows | 1.18 | amd64 |
| Windows | 1.17 | amd64 |
| Windows | 1.19 | 386 |
| Windows | 1.18 | 386 |
| Windows | 1.17 | 386 |

While this project should work for other systems, no compatibility guarantees
are made for those systems currently.
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/ec2/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/ec2

go 1.17
go 1.18

require (
github.com/aws/aws-sdk-go v1.44.96
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/ecs/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/ecs

go 1.17
go 1.18

require (
github.com/stretchr/testify v1.8.0
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/eks/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/eks

go 1.17
go 1.18

require (
github.com/stretchr/testify v1.8.0
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/lambda/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/lambda

go 1.17
go 1.18

require (
github.com/stretchr/testify v1.8.0
Expand Down
2 changes: 1 addition & 1 deletion detectors/gcp/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/gcp

go 1.17
go 1.18

require (
cloud.google.com/go/compute v1.9.0
Expand Down
2 changes: 1 addition & 1 deletion go.mod
@@ -1,3 +1,3 @@
module go.opentelemetry.io/contrib

go 1.17
go 1.18
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama/example

go 1.17
go 1.18

replace go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama => ../

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama

go 1.17
go 1.18

require (
github.com/Shopify/sarama v1.36.0
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama/test

go 1.17
go 1.18

require (
github.com/Shopify/sarama v1.36.0
Expand Down
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.17-alpine AS base
FROM golang:1.18-alpine AS base
COPY . /src/
WORKDIR /src/instrumentation/github.com/astaxie/beego/otelbeego/example

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego/example

go 1.17
go 1.18

replace (
go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego => ../
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego

go 1.17
go 1.18

replace go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp => ../../../../net/http/otelhttp

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego/test

go 1.17
go 1.18

require (
github.com/astaxie/beego v1.12.3
Expand Down
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM golang:1.17 AS base
FROM golang:1.18 AS base
COPY . /src/
WORKDIR /src/instrumentation/github.com/aws/aws-lambda-go/otellambda/example
RUN apt-get update
Expand All @@ -25,4 +25,4 @@ RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2
&& ./aws/install
RUN apt-get -y install jq

CMD ["./build.sh"]
CMD ["./build.sh"]
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/example

go 1.17
go 1.18

replace (
go.opentelemetry.io/contrib/detectors/aws/lambda => ../../../../../../detectors/aws/lambda
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda

go 1.17
go 1.18

require (
github.com/aws/aws-lambda-go v1.34.1
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/test

go 1.17
go 1.18

replace (
go.opentelemetry.io/contrib/detectors/aws/lambda => ../../../../../../detectors/aws/lambda
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig

go 1.17
go 1.18

replace (
go.opentelemetry.io/contrib/detectors/aws/lambda => ../../../../../../detectors/aws/lambda
Expand Down
Expand Up @@ -11,10 +11,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM golang:1.17-alpine AS base
FROM golang:1.18-alpine AS base
COPY . /src/
WORKDIR /src/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/example

FROM base AS aws-client
RUN go install ./main.go
CMD ["/go/bin/main"]
CMD ["/go/bin/main"]
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/example

go 1.17
go 1.18

replace go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws => ../

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws

go 1.17
go 1.18

require (
github.com/aws/aws-sdk-go-v2 v1.16.14
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/test

go 1.17
go 1.18

require (
github.com/aws/aws-sdk-go-v2 v1.16.14
Expand Down
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM golang:1.17-alpine AS base
FROM golang:1.18-alpine AS base
COPY . /src/
WORKDIR /src/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/example

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/example

go 1.17
go 1.18

replace go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache => ../

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache

go 1.17
go 1.18

require (
github.com/bradfitz/gomemcache v0.0.0-20190913173617-a41fca850d0b
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/test

go 1.17
go 1.18

require (
github.com/bradfitz/gomemcache v0.0.0-20190913173617-a41fca850d0b
Expand Down
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM golang:1.17-alpine AS base
FROM golang:1.18-alpine AS base
COPY . /src/
WORKDIR /src/instrumentation/github.com/emicklei/go-restful/otelrestful/example

Expand Down
Expand Up @@ -14,7 +14,7 @@
version: "3.7"
services:
go-restful-client:
image: golang:1.17-alpine
image: golang:1.18-alpine
networks:
- example
command:
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful/example

go 1.17
go 1.18

replace (
go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful => ../
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful

go 1.17
go 1.18

replace go.opentelemetry.io/contrib/propagators/b3 => ../../../../../propagators/b3

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful/test

go 1.17
go 1.18

require (
github.com/emicklei/go-restful/v3 v3.9.0
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin/example

go 1.17
go 1.18

replace (
go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin => ../
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gin-gonic/gin/otelgin/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin

go 1.17
go 1.18

replace go.opentelemetry.io/contrib/propagators/b3 => ../../../../../propagators/b3

Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin/test

go 1.17
go 1.18

require (
github.com/gin-gonic/gin v1.8.1
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit/example

go 1.17
go 1.18

require (
github.com/gorilla/mux v1.8.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/go-kit/kit/otelkit/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit

go 1.17
go 1.18

require (
github.com/go-kit/kit v0.12.0
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit/test

go 1.17
go 1.18

require (
github.com/go-kit/kit v0.12.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gocql/gocql/otelgocql/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql

go 1.17
go 1.18

require (
github.com/gocql/gocql v0.0.0-20200624222514-34081eda590e
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql/test

go 1.17
go 1.18

require (
github.com/gocql/gocql v0.0.0-20210707082121-9a3953d1826d
Expand Down
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux/example

go 1.17
go 1.18

replace go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux => ../

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gorilla/mux/otelmux/go.mod
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux

go 1.17
go 1.18

require (
github.com/felixge/httpsnoop v1.0.3
Expand Down