Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add support for additional attributes #4828

Closed
codeboten opened this issue Jan 18, 2024 · 2 comments · Fixed by #4832
Closed

config: add support for additional attributes #4828

codeboten opened this issue Jan 18, 2024 · 2 comments · Fixed by #4832
Assignees
@codeboten
Labels
area: config Related to config functionality

Comments

@codeboten
Copy link
Contributor

The Resource model only supports a ServiceName attribute.

opentelemetry-go-contrib/config/generated_config.go

Lines 19 to 22 in 044e09a

type Attributes struct {
// ServiceName corresponds to the JSON schema field "service.name".
ServiceName *string `mapstructure:"service.name,omitempty"`
}

This should be updated to support additional attributes as pointed out by @pellared here: #4824 (comment)
@codeboten codeboten mentioned this issue Jan 18, 2024
Merged
@pellared pellared added the area: config Related to config functionality label Jan 18, 2024
@pellared pellared mentioned this issue Jan 18, 2024
Closed
@codeboten
Copy link
Contributor Author

please assign to me :)

This was referenced Jan 19, 2024
Closed
Merged
@AkhigbeEromo
Copy link

Hello @pellared @codeboten i wanted to ask if this issue has already been solved and if it has not what other attributes would you like to be added. i am also open to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
area: config Related to config functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: add support for additional properties in resource codeboten/opentelemetry-go-contrib
3 participants
@codeboten @pellared @AkhigbeEromo