config: refactor resource code #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the resource code out of config.go and into resource.go. Fixes open-telemetry#4821 Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4824 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 150 151 +1
Lines 10890 10890
=====================================
+ Hits 8858 8862 +4
+ Misses 1873 1869 -4
Partials 159 159
|
|
@pellared not sure if this warrants a changelog entry or not |
pellared
added
the
Skip Changelog
dashpole
approved these changes
Jan 18, 2024
pellared
approved these changes
Jan 18, 2024
MrAlias
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the resource code out of config.go and into resource.go.
Fixes #4821