config: add support for additional properties in resource #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4832 +/- ##
=======================================
+ Coverage 62.4% 62.5% +0.1%
=======================================
Files 191 191
Lines 11690 11727 +37
=======================================
+ Hits 7303 7340 +37
Misses 4170 4170
Partials 217 217
|
codeboten
force-pushed
the
codeboten/resource-additional-attributes
branch
from
90cead7
to
f37afc0
Compare
This allows the configuration of other attributes than service.name. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/resource-additional-attributes
branch
from
f37afc0
to
af7a01a
Compare
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
requested review from
MadVikingGod,
pellared and
a team
as code owners
This was referenced Apr 23, 2024
MadVikingGod
approved these changes
Apr 26, 2024
|
This would be a pretty cool change 👍🏼 |
MrAlias
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the configuration of other attributes than service.name.
I'm using a personal fork of go-jsonschema to test out that the implementation would work for otel-config's use-caseSupport for additional properties is now available in the go-jsonschema library, updated the PR accordingly
Fixes #4828