Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2260 where attributes for DynamoDB were not added becaus… #2272

Merged
merged 5 commits into from May 24, 2022

Conversation

noliva
Copy link
Contributor

@noliva noliva commented May 13, 2022

…e of a wrong name in the servicemap. #2260

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 13, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: noliva / name: Natanael Oliva (6c127ab)

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you add a CHANGELOG.md entry and get the CLA sorted then we can merge this?

…t added because of a wrong name in the servicemap.
@noliva noliva force-pushed the noliva/fix-dynamodb-resource-name branch from 8246331 to 6c127ab Compare May 16, 2022 13:38
@MrAlias
Copy link
Contributor

MrAlias commented May 16, 2022

Please fix the CI failure. Likely running make precommit will do the trick.

@MrAlias MrAlias requested a review from dmathieu as a code owner May 24, 2022 15:08
@MrAlias MrAlias merged commit f8c1f00 into open-telemetry:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants