Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2260 where attributes for DynamoDB were not added becaus… #2272

Merged
merged 5 commits into from May 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -26,6 +26,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
This makes `4xx` response codes to not be an error anymore. (#1973)
- Fixed jaegerremote sampler not behaving properly with per operation strategy set. (#2137)
- Stopped injecting propagation context into response headers in otelhttp. (#2180)
- Fix issue where attributes for DynamoDB were not added because of a string miss match. (#2272)

## [1.6.0/0.31.0] - 2022-03-28

Expand Down
Expand Up @@ -17,6 +17,8 @@ package otelaws // import "go.opentelemetry.io/contrib/instrumentation/github.co
import (
"context"

"github.com/aws/aws-sdk-go-v2/service/dynamodb"

v2Middleware "github.com/aws/aws-sdk-go-v2/aws/middleware"
"github.com/aws/smithy-go/middleware"

Expand All @@ -32,7 +34,7 @@ const (
)

var servicemap = map[string]AttributeSetter{
"dynamodb": DynamoDBAttributeSetter,
dynamodb.ServiceID: DynamoDBAttributeSetter,
}

// OperationAttr returns the AWS operation attribute.
Expand Down
Expand Up @@ -25,7 +25,7 @@ import (
semconv "go.opentelemetry.io/otel/semconv/v1.10.0"
)

// DynamoDBAttributeSetter sets DynamoDB specific attributes depending on the the DynamoDB operation being performed.
// DynamoDBAttributeSetter sets DynamoDB specific attributes depending on the DynamoDB operation being performed.
func DynamoDBAttributeSetter(ctx context.Context, in middleware.InitializeInput) []attribute.KeyValue {
dynamodbAttributes := []attribute.KeyValue{semconv.DBSystemKey.String("dynamodb")}

Expand Down