AWS Otel middleware not populating attributes for DynamoDB

[noliva]

Background

When using the Otel middleware, no attributes like tableName get populated in the span.

This is how I'm instrumenting the code.

awsCfg, err := awsConfig.LoadDefaultConfig(ctx)
if err != nil {
    panic("configuration error, " + err.Error())
}

otelaws.AppendMiddlewares(&awsCfg.APIOptions)

client := dynamodb.NewFromConfig(cfg)

When the middleware is trying to detect the ServiceID here the function returns DynamoDB, however, when it later looks for the DefaultAttributeSetter it can not get the DynamoDBAttributeSetter because the servicemap looks like this

var servicemap = map[string]AttributeSetter{
	"dynamodb": DynamoDBAttributeSetter,
}

The key of the map references the signingNameKey and not the serviceIDKey.

Proposal

I believe that the servicemap should be updated to reflect the serviceIDKey, so it would look like this.

var servicemap = map[string]AttributeSetter{
	"DynamoDB": DynamoDBAttributeSetter,
}

Is that the case or am I doing something wrong in the process?

[Aneurysm9]

I think your analysis is correct. Can you open a PR to update this? As the dynamodb.ServiceID constant is exported it might be best to use that rather than a string literal.

[noliva]

Thank you for looking into this, yes, I will open a PR to address this.

[MrAlias]

This looks to have been resolved by #2272