[mdatagen] add support for async instruments #10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ability to configure asynchronous (observable) instruments via mdatagen. This requires providing a mechanism to set options to pass in the callbacks that will be called at the time of the observation. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 15, 2024
This PR follows open-telemetry#10159 and uses the new mdatagen functionality to generate async metrics in the service. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10159 +/- ##
==========================================
+ Coverage 91.69% 91.80% +0.11%
==========================================
Files 366 356 -10
Lines 16791 16883 +92
==========================================
+ Hits 15396 15500 +104
+ Misses 1056 1038 -18
- Partials 339 345 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
TylerHelmuth
approved these changes
May 16, 2024
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 21, 2024
This PR follows open-telemetry#10159 and uses the new mdatagen functionality to generate async metrics in the service. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
This PR adds the ability to configure asynchronous (observable) instruments via mdatagen. This requires providing a mechanism to set options to pass in the callbacks that will be called at the time of the observation. --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
added a commit
that referenced
this pull request
May 30, 2024
This PR follows #10159 and uses the new mdatagen functionality to generate async metrics in the service. --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure asynchronous (observable) instruments via mdatagen. This requires providing a mechanism to set options to pass in the callbacks that will be called at the time of the observation.