Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] use mdatagen to generate service metrics #10160

Merged
merged 4 commits into from
May 30, 2024

Conversation

codeboten
Copy link
Contributor

This PR follows #10159 and uses the new mdatagen functionality to generate async metrics in the service.

This PR follows open-telemetry#10159 and uses the new mdatagen functionality to generate
async metrics in the service.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten marked this pull request as ready for review May 21, 2024 19:16
@codeboten codeboten requested a review from a team as a code owner May 21, 2024 19:16
@codeboten codeboten requested a review from jpkrohling May 21, 2024 19:16
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 98.93617% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.01%. Comparing base (d294537) to head (5067f03).
Report is 3 commits behind head on main.

Files Patch % Lines
service/service.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10160      +/-   ##
==========================================
+ Coverage   91.90%   92.01%   +0.10%     
==========================================
  Files         361      362       +1     
  Lines       16970    16998      +28     
==========================================
+ Hits        15596    15640      +44     
+ Misses       1032     1019      -13     
+ Partials      342      339       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 10bcef3 into open-telemetry:main May 30, 2024
49 checks passed
@codeboten codeboten deleted the codeboten/service-mdatagen branch May 30, 2024 16:40
@github-actions github-actions bot added this to the next release milestone May 30, 2024
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request May 30, 2024
codeboten added a commit that referenced this pull request May 30, 2024
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants