Updates the GAT syntax #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per rust-lang/rust#89122, GATs no longer use the `type Typename<'a> where Self: 'a = ... ` syntax rather they move the where to the end. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129
added a commit
to open-rmf/rmf_crowdsim
that referenced
this pull request
Nov 10, 2022
…iles with recent rust nightlies. Mapf was not compiling with the latest nightlies causing crowdsim not to be compiling. I have updated them the branch upstream (see open-rmf/mapf#7) to make it work. Once this is merged we may close this PR. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
mxgrey
pushed a commit
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per rust-lang/rust#89122, GATs no longer use the
type Typename<'a> where Self: 'a = ...syntax rather they move the where to the end.This PR also fixes lifetimes. Seems like the
type_alias_impl_traitrequires you to specify a lifetime.Signed-off-by: Arjo Chakravarty arjo@openrobotics.org