Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle: dont sign manifest when empty #4730

Merged
merged 1 commit into from
Jun 2, 2022
Merged

bundle: dont sign manifest when empty #4730

merged 1 commit into from
Jun 2, 2022

Commits on Jun 2, 2022

  1. bundle: dont sign manifest when empty

    Previously, when creating a signed bundle and either no `.manifest`
    file is present or when the contents are the defaults, no `.manifest`
    file would get written to the `.tar.gz` output but there would be an
    entry for the manifest in the `.signatures.json` file when trying to
    verify the bundle. Now, hashing/signing the manifest file is skipped
    when it is empty or not present.
    
    Fixes #4712
    
    Signed-off-by: Matt F <15720856+friedrichsenm@users.noreply.github.com>
    friedrichsenm committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    4c3b0d5 View commit details
    Browse the repository at this point in the history