bundle: dont sign manifest when empty #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when creating a signed bundle and either no `.manifest` file is present or when the contents are the defaults, no `.manifest` file would get written to the `.tar.gz` output but there would be an entry for the manifest in the `.signatures.json` file when trying to verify the bundle. Now, hashing/signing the manifest file is skipped when it is empty or not present. Fixes #4712 Signed-off-by: Matt F <15720856+friedrichsenm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when creating a signed bundle and either no
.manifestfile is present or when the contents are the defaults, no
.manifestfile would get written to the
.tar.gzoutput but there would be anentry for the manifest in the
.signatures.jsonfile when trying toverify the bundle. I modified the signature process to skip hashing
the manifest when it is empty for whatever reason.
Fixes #4712
Signed-off-by: Matt F 15720856+friedrichsenm@users.noreply.github.com