Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradient-2 with bfloat16 #6097

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thiagocrepaldi
Copy link
Contributor

@thiagocrepaldi thiagocrepaldi commented Apr 23, 2024

Repro for bug #6098
Follow-up for #6079

onnx/defs/training/old.cc Fixed Show fixed Hide fixed
onnx/defs/training/old.cc Fixed Show fixed Hide fixed
@justinchuby
Copy link
Contributor

justinchuby commented Apr 24, 2024

Since the preview ops are discouraged from being used (and I believe not used by ort), I wonder if it is worth upgrading?

@thiagocrepaldi
Copy link
Contributor Author

This is a repro for the schema error bug reported by #6098

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (83194ed) to head (fcc8731).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6097      +/-   ##
==========================================
+ Coverage   56.95%   57.03%   +0.08%     
==========================================
  Files         506      506              
  Lines       30467    30935     +468     
  Branches     4592     4592              
==========================================
+ Hits        17353    17645     +292     
- Misses      12285    12465     +180     
+ Partials      829      825       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

#include <algorithm>
#include <cmath>

// #include "onnx/defs/function.h"

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants