Check that graph outputs are defined #6070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinchuby
approved these changes
Apr 8, 2024
justinchuby
approved these changes
Apr 8, 2024
xadupre
approved these changes
Apr 9, 2024
|
For some reason the ado pipelines are not kicking off |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6070 +/- ##
==========================================
+ Coverage 56.95% 56.99% +0.04%
==========================================
Files 506 506
Lines 30467 30489 +22
Branches 4592 4593 +1
==========================================
+ Hits 17353 17378 +25
+ Misses 12285 12284 -1
+ Partials 829 827 -2 ☔ View full report in Codecov by Sentry. |
Bumps [reviewdog/action-shellcheck](https://github.com/reviewdog/action-shellcheck) from 1.19.0 to 1.20.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/reviewdog/action-shellcheck/releases">reviewdog/action-shellcheck's releases</a>.</em></p> <blockquote> <h2>Release v1.20.0</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): update koalaman/shellcheck to 0.10.0 by <a href="https://github.com/grische"><code>@grische</code></a> in <a href="https://redirect.github.com/reviewdog/action-shellcheck/pull/58">reviewdog/action-shellcheck#58</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/reviewdog/action-shellcheck/compare/v1.19...v1.20.0">https://github.com/reviewdog/action-shellcheck/compare/v1.19...v1.20.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/reviewdog/action-shellcheck/commit/72365a51bf6476fe952a117c3ff703eb7775e40a"><code>72365a5</code></a> Merge pull request <a href="https://redirect.github.com/reviewdog/action-shellcheck/issues/58">#58</a> from grische/update/shellcheck</li> <li><a href="https://github.com/reviewdog/action-shellcheck/commit/d6513905e792840dffabb7376d1ce51701c55b81"><code>d651390</code></a> chore(deps): update koalaman/shellcheck to 0.10.0</li> <li>See full diff in <a href="https://github.com/reviewdog/action-shellcheck/compare/96fa305c16b0f9cc9b093af22dcd09de1c8f1c2d...72365a51bf6476fe952a117c3ff703eb7775e40a">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.0.0 to 5.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p> <blockquote> <h2>v5.1.0</h2> <h2>What's Changed</h2> <ul> <li>Leveraging the raw API to retrieve the version-manifest, as it does not impose a rate limit and hence facilitates unrestricted consumption without the need for a token for Github Enterprise Servers by <a href="https://github.com/Shegox"><code>@Shegox</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/766">actions/setup-python#766</a>.</li> <li>Dependency updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> and <a href="https://github.com/HarithaVattikuti"><code>@HarithaVattikuti</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/817">actions/setup-python#817</a></li> <li>Documentation changes for version in README by <a href="https://github.com/basnijholt"><code>@basnijholt</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/776">actions/setup-python#776</a></li> <li>Documentation changes for link in README by <a href="https://github.com/ukd1"><code>@ukd1</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/793">actions/setup-python#793</a></li> <li>Documentation changes for link in Advanced Usage by <a href="https://github.com/Jamim"><code>@Jamim</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/782">actions/setup-python#782</a></li> <li>Documentation changes for avoiding rate limit issues on GHES by <a href="https://github.com/priya-kinthali"><code>@priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/835">actions/setup-python#835</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/basnijholt"><code>@basnijholt</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/776">actions/setup-python#776</a></li> <li><a href="https://github.com/ukd1"><code>@ukd1</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/793">actions/setup-python#793</a></li> <li><a href="https://github.com/Jamim"><code>@Jamim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/782">actions/setup-python#782</a></li> <li><a href="https://github.com/Shegox"><code>@Shegox</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/766">actions/setup-python#766</a></li> <li><a href="https://github.com/priya-kinthali"><code>@priya-kinthali</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/835">actions/setup-python#835</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0">https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-python/commit/82c7e631bb3cdc910f68e0081d67478d79c6982d"><code>82c7e63</code></a> Documentation changes for avoiding rate limit issues on GHES (<a href="https://redirect.github.com/actions/setup-python/issues/835">#835</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/10aa35afd7f071e70ffaa122e3d7c6ffcb5f7ed1"><code>10aa35a</code></a> feat: fallback to raw endpoint for manifest when rate limit is reached (<a href="https://redirect.github.com/actions/setup-python/issues/766">#766</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/9a7ac94420f42ee15fc60ab88d0dca4be1fd5757"><code>9a7ac94</code></a> Bump undici from 5.27.2 to 5.28.3 (<a href="https://redirect.github.com/actions/setup-python/issues/817">#817</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/871daa956ca9ea99f3c3e30acb424b7960676734"><code>871daa9</code></a> Fix the "Specifying multiple Python/PyPy versions" link (<a href="https://redirect.github.com/actions/setup-python/issues/782">#782</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/2f078955e4d0f34cc7a8b0108b2eb7bbe154438e"><code>2f07895</code></a> Fix broken README.md link (<a href="https://redirect.github.com/actions/setup-python/issues/793">#793</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/e9d6f990972a57673cdb72ec29e19d42ba28880f"><code>e9d6f99</code></a> Replace setup-python@v4 by setup-python@v5 in README (<a href="https://redirect.github.com/actions/setup-python/issues/776">#776</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-python/compare/0a5c61591373683505ea898e09a3ea4f39ef2b9c...82c7e631bb3cdc910f68e0081d67478d79c6982d">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
### Description <!-- - Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
…nnx#6051) Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
### Description Intermediate results can only be printed right now. With this PR, they can be returned as well. ### Motivation and Context See onnx#6025. --------- Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
### Description typo ### Motivation and Context typo fix Signed-off-by: RoboSchmied <github@roboschmie.de> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.3.0 to 0.3.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/releases">ruff's releases</a>.</em></p> <blockquote> <h2>v0.3.5</h2> <h2>Changes</h2> <h3>Preview features</h3> <ul> <li>[<code>pylint</code>] Implement <code>modified-iterating-set</code> (<code>E4703</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10473">#10473</a>)</li> <li>[<code>refurb</code>] Implement <code>for-loop-set-mutations</code> (<code>FURB142</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10583">#10583</a>)</li> <li>[<code>refurb</code>] Implement <code>unnecessary-from-float</code> (<code>FURB164</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10647">#10647</a>)</li> <li>[<code>refurb</code>] Implement <code>verbose-decimal-constructor</code> (<code>FURB157</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10533">#10533</a>)</li> </ul> <h3>Rule changes</h3> <ul> <li>[<code>flake8-comprehensions</code>] Handled special case for <code>C401</code> which also matches <code>C416</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10596">#10596</a>)</li> <li>[<code>flake8-pyi</code>] Mark <code>unaliased-collections-abc-set-import</code> fix as "safe" for more cases in stub files (<code>PYI025</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10547">#10547</a>)</li> <li>[<code>numpy</code>] Add <code>row_stack</code> to NumPy 2.0 migration rule (<a href="https://redirect.github.com/astral-sh/ruff/pull/10646">#10646</a>)</li> <li>[<code>pycodestyle</code>] Allow cell magics before an import (<code>E402</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10545">#10545</a>)</li> <li>[<code>pycodestyle</code>] Avoid blank line rules for the first logical line in cell (<a href="https://redirect.github.com/astral-sh/ruff/pull/10291">#10291</a>)</li> </ul> <h3>Configuration</h3> <ul> <li>Respected nested namespace packages (<a href="https://redirect.github.com/astral-sh/ruff/pull/10541">#10541</a>)</li> <li>[<code>flake8-boolean-trap</code>] Add setting for user defined allowed boolean trap (<a href="https://redirect.github.com/astral-sh/ruff/pull/10531">#10531</a>)</li> </ul> <h3>Bug fixes</h3> <ul> <li>Correctly handle references in <code>__all__</code> definitions when renaming symbols in autofixes (<a href="https://redirect.github.com/astral-sh/ruff/pull/10527">#10527</a>)</li> <li>Track ranges of names inside <code>__all__</code> definitions (<a href="https://redirect.github.com/astral-sh/ruff/pull/10525">#10525</a>)</li> <li>[<code>flake8-bugbear</code>] Avoid false positive for usage after <code>continue</code> (<code>B031</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10539">#10539</a>)</li> <li>[<code>flake8-copyright</code>] Accept commas in default copyright pattern (<a href="https://redirect.github.com/astral-sh/ruff/pull/9498">#9498</a>)</li> <li>[<code>flake8-datetimez</code>] Allow f-strings with <code>%z</code> for <code>DTZ007</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10651">#10651</a>)</li> <li>[<code>flake8-pytest-style</code>] Fix <code>PT014</code> autofix for last item in list (<a href="https://redirect.github.com/astral-sh/ruff/pull/10532">#10532</a>)</li> <li>[<code>flake8-quotes</code>] Ignore <code>Q000</code>, <code>Q001</code> when string is inside forward ref (<a href="https://redirect.github.com/astral-sh/ruff/pull/10585">#10585</a>)</li> <li>[<code>isort</code>] Always place non-relative imports after relative imports (<a href="https://redirect.github.com/astral-sh/ruff/pull/10669">#10669</a>)</li> <li>[<code>isort</code>] Respect Unicode characters in import sorting (<a href="https://redirect.github.com/astral-sh/ruff/pull/10529">#10529</a>)</li> <li>[<code>pyflakes</code>] Fix F821 false negatives when <code>from __future__ import annotations</code> is active (attempt 2) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10524">#10524</a>)</li> <li>[<code>pyflakes</code>] Make <code>unnecessary-lambda</code> an always-unsafe fix (<a href="https://redirect.github.com/astral-sh/ruff/pull/10668">#10668</a>)</li> <li>[<code>pylint</code>] Fixed false-positive on the rule <code>PLW1641</code> (<code>eq-without-hash</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10566">#10566</a>)</li> <li>[<code>ruff</code>] Fix panic in unused <code># noqa</code> removal with multi-byte space (<code>RUF100</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10682">#10682</a>)</li> </ul> <h3>Documentation</h3> <ul> <li>Add PR title format to <code>CONTRIBUTING.md</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10665">#10665</a>)</li> <li>Fix list markup to include blank lines required (<a href="https://redirect.github.com/astral-sh/ruff/pull/10591">#10591</a>)</li> <li>Put <code>flake8-logging</code> next to the other flake8 plugins in registry (<a href="https://redirect.github.com/astral-sh/ruff/pull/10587">#10587</a>)</li> <li>[<code>flake8-bandit</code>] Update warning message for rule <code>S305</code> to address insecure block cipher mode use (<a href="https://redirect.github.com/astral-sh/ruff/pull/10602">#10602</a>)</li> <li>[<code>flake8-bugbear</code>] Document use of anonymous assignment in <code>useless-expression</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10551">#10551</a>)</li> <li>[<code>flake8-datetimez</code>] Clarify error messages and docs for <code>DTZ</code> rules (<a href="https://redirect.github.com/astral-sh/ruff/pull/10621">#10621</a>)</li> <li>[<code>pycodestyle</code>] Use same before vs. after numbers for <code>space-around-operator</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10640">#10640</a>)</li> <li>[<code>ruff</code>] Change <code>quadratic-list-summation</code> docs to use <code>iadd</code> consistently (<a href="https://redirect.github.com/astral-sh/ruff/pull/10666">#10666</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md">ruff's changelog</a>.</em></p> <blockquote> <h2>0.3.5</h2> <h3>Preview features</h3> <ul> <li>[<code>pylint</code>] Implement <code>modified-iterating-set</code> (<code>E4703</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10473">#10473</a>)</li> <li>[<code>refurb</code>] Implement <code>for-loop-set-mutations</code> (<code>FURB142</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10583">#10583</a>)</li> <li>[<code>refurb</code>] Implement <code>unnecessary-from-float</code> (<code>FURB164</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10647">#10647</a>)</li> <li>[<code>refurb</code>] Implement <code>verbose-decimal-constructor</code> (<code>FURB157</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10533">#10533</a>)</li> </ul> <h3>Rule changes</h3> <ul> <li>[<code>flake8-comprehensions</code>] Handled special case for <code>C401</code> which also matches <code>C416</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10596">#10596</a>)</li> <li>[<code>flake8-pyi</code>] Mark <code>unaliased-collections-abc-set-import</code> fix as "safe" for more cases in stub files (<code>PYI025</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10547">#10547</a>)</li> <li>[<code>numpy</code>] Add <code>row_stack</code> to NumPy 2.0 migration rule (<a href="https://redirect.github.com/astral-sh/ruff/pull/10646">#10646</a>)</li> <li>[<code>pycodestyle</code>] Allow cell magics before an import (<code>E402</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10545">#10545</a>)</li> <li>[<code>pycodestyle</code>] Avoid blank line rules for the first logical line in cell (<a href="https://redirect.github.com/astral-sh/ruff/pull/10291">#10291</a>)</li> </ul> <h3>Configuration</h3> <ul> <li>Respected nested namespace packages (<a href="https://redirect.github.com/astral-sh/ruff/pull/10541">#10541</a>)</li> <li>[<code>flake8-boolean-trap</code>] Add setting for user defined allowed boolean trap (<a href="https://redirect.github.com/astral-sh/ruff/pull/10531">#10531</a>)</li> </ul> <h3>Bug fixes</h3> <ul> <li>Correctly handle references in <code>__all__</code> definitions when renaming symbols in autofixes (<a href="https://redirect.github.com/astral-sh/ruff/pull/10527">#10527</a>)</li> <li>Track ranges of names inside <code>__all__</code> definitions (<a href="https://redirect.github.com/astral-sh/ruff/pull/10525">#10525</a>)</li> <li>[<code>flake8-bugbear</code>] Avoid false positive for usage after <code>continue</code> (<code>B031</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10539">#10539</a>)</li> <li>[<code>flake8-copyright</code>] Accept commas in default copyright pattern (<a href="https://redirect.github.com/astral-sh/ruff/pull/9498">#9498</a>)</li> <li>[<code>flake8-datetimez</code>] Allow f-strings with <code>%z</code> for <code>DTZ007</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10651">#10651</a>)</li> <li>[<code>flake8-pytest-style</code>] Fix <code>PT014</code> autofix for last item in list (<a href="https://redirect.github.com/astral-sh/ruff/pull/10532">#10532</a>)</li> <li>[<code>flake8-quotes</code>] Ignore <code>Q000</code>, <code>Q001</code> when string is inside forward ref (<a href="https://redirect.github.com/astral-sh/ruff/pull/10585">#10585</a>)</li> <li>[<code>isort</code>] Always place non-relative imports after relative imports (<a href="https://redirect.github.com/astral-sh/ruff/pull/10669">#10669</a>)</li> <li>[<code>isort</code>] Respect Unicode characters in import sorting (<a href="https://redirect.github.com/astral-sh/ruff/pull/10529">#10529</a>)</li> <li>[<code>pyflakes</code>] Fix F821 false negatives when <code>from __future__ import annotations</code> is active (attempt 2) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10524">#10524</a>)</li> <li>[<code>pyflakes</code>] Make <code>unnecessary-lambda</code> an always-unsafe fix (<a href="https://redirect.github.com/astral-sh/ruff/pull/10668">#10668</a>)</li> <li>[<code>pylint</code>] Fixed false-positive on the rule <code>PLW1641</code> (<code>eq-without-hash</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10566">#10566</a>)</li> <li>[<code>ruff</code>] Fix panic in unused <code># noqa</code> removal with multi-byte space (<code>RUF100</code>) (<a href="https://redirect.github.com/astral-sh/ruff/pull/10682">#10682</a>)</li> </ul> <h3>Documentation</h3> <ul> <li>Add PR title format to <code>CONTRIBUTING.md</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10665">#10665</a>)</li> <li>Fix list markup to include blank lines required (<a href="https://redirect.github.com/astral-sh/ruff/pull/10591">#10591</a>)</li> <li>Put <code>flake8-logging</code> next to the other flake8 plugins in registry (<a href="https://redirect.github.com/astral-sh/ruff/pull/10587">#10587</a>)</li> <li>[<code>flake8-bandit</code>] Update warning message for rule <code>S305</code> to address insecure block cipher mode use (<a href="https://redirect.github.com/astral-sh/ruff/pull/10602">#10602</a>)</li> <li>[<code>flake8-bugbear</code>] Document use of anonymous assignment in <code>useless-expression</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10551">#10551</a>)</li> <li>[<code>flake8-datetimez</code>] Clarify error messages and docs for <code>DTZ</code> rules (<a href="https://redirect.github.com/astral-sh/ruff/pull/10621">#10621</a>)</li> <li>[<code>pycodestyle</code>] Use same before vs. after numbers for <code>space-around-operator</code> (<a href="https://redirect.github.com/astral-sh/ruff/pull/10640">#10640</a>)</li> <li>[<code>ruff</code>] Change <code>quadratic-list-summation</code> docs to use <code>iadd</code> consistently (<a href="https://redirect.github.com/astral-sh/ruff/pull/10666">#10666</a>)</li> </ul> <h2>0.3.4</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/astral-sh/ruff/commit/200ebeebdc8ab8ee14f56922e21b218f41a5a7e4"><code>200ebee</code></a> Bump version to v0.3.5 (<a href="https://redirect.github.com/astral-sh/ruff/issues/10717">#10717</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/23e8279093d8f891fc8bb59ebea2532649801ed3"><code>23e8279</code></a> chore(deps): update npm development dependencies (<a href="https://redirect.github.com/astral-sh/ruff/issues/10716">#10716</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/221b3236a8770e2f9a0c502290b78a5ec58698cc"><code>221b323</code></a> chore(deps): update strum to 0.26.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/10715">#10715</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/a0e15448488badd81b0924653c180cd18029b2c2"><code>a0e1544</code></a> chore(deps): update rust crate pep440_rs to 0.5.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/10703">#10703</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/2740fab7ad8963892d15581e624764c7a7894999"><code>2740fab</code></a> Renovate: group all <code>strum</code> dependencies together (<a href="https://redirect.github.com/astral-sh/ruff/issues/10714">#10714</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/7042b9b16dcb91ffa6a49bab6e8d43066131af2a"><code>7042b9b</code></a> fix(deps): update rust crate similar to v2.5.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/10711">#10711</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/4047d456b6e1b5bfd67cf81b921350e2f2989a6c"><code>4047d45</code></a> chore(deps): update rust crate insta to v1.38.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/10701">#10701</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/20d69ea504b95e4cd7751dbb5a17aa446721945d"><code>20d69ea</code></a> chore(deps): update npm development dependencies (<a href="https://redirect.github.com/astral-sh/ruff/issues/10697">#10697</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/d021cac0c9755e7f34ee3941c9a98aa7befa9750"><code>d021cac</code></a> chore(deps): update rust crate tracing-tree to 0.3.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/10709">#10709</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/46369d48fe1089d48e0590fcf6fb028218ab84b0"><code>46369d4</code></a> chore(deps): update rust crate uuid to v1.8.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/10710">#10710</a>)</li> <li>Additional commits viewable in <a href="https://github.com/astral-sh/ruff/compare/v0.3.0...v0.3.5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies. Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Migrate CI to use Github Actions. Update Google Test to a newer version (some version in 2022). The latest commit has errors I don't know how to fix. Use `FetchContent` instead of `ExternalProject` to bring in googletest according to its documentation https://google.github.io/googletest/quickstart-cmake.html Fixes onnx#6074 Fixes onnx#6073 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
### Description Possible fix for onnx#6047 based on https://stackoverflow.com/questions/33149878/experimentalfilesystem-linker-error/33159746#33159746 ### Motivation and Context I'm not a cmake expert so there may be a better way to do this. This did allow me to build ONNX 1.16 on RHEL 8. --------- Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com> Signed-off-by: Charles Volzka <42243335+cjvolzka@users.noreply.github.com> Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Add a unit test for the fix introduced by onnx#6049 --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam
force-pushed
the
output-check
branch
from
96cb924
to
1fdb14f
Compare
|
I am closing this and opening a new PR. The signoff got messed in one commit :-( ... one small "-s" forgotten, and so much complication! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
The current checker does not check that all graph outputs are defined. This PR adds such a check. (See issue #6040 ). Note: We probably also want a separate check to ensure that a graph-input is not used as a graph-output. But leaving that for a separate PR, since it is a distinctly different check (and perhaps might require a different discussion). Redo of PR #6070 Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current checker does not check that all graph outputs are defined. This PR adds such a check. (See issue #6040 ).
Note: We probably also want a separate check to ensure that a graph-input is not used as a graph-output. But leaving that for a separate PR, since it is a distinctly different check (and perhaps might require a different discussion).