Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check graph outputs are defined #6083

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

gramalingam
Copy link
Contributor

The current checker does not check that all graph outputs are defined. This PR adds such a check. (See issue #6040 ).

Note: We probably also want a separate check to ensure that a graph-input is not used as a graph-output. But leaving that for a separate PR, since it is a distinctly different check (and perhaps might require a different discussion).

Redo of PR #6070

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam requested a review from a team as a code owner April 12, 2024 20:31
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.05%. Comparing base (83194ed) to head (9b4ca5e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6083      +/-   ##
==========================================
+ Coverage   56.95%   57.05%   +0.09%     
==========================================
  Files         506      506              
  Lines       30467    30489      +22     
  Branches     4592     4593       +1     
==========================================
+ Hits        17353    17394      +41     
+ Misses      12285    12269      -16     
+ Partials      829      826       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added this pull request to the merge queue Apr 12, 2024
Merged via the queue into onnx:main with commit 990cb66 Apr 12, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants