Fix get highest executed and finalized height #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5903 +/- ##
==========================================
- Coverage 55.61% 55.59% -0.02%
==========================================
Files 1127 1127
Lines 88838 88833 -5
==========================================
- Hits 49408 49389 -19
- Misses 34721 34737 +16
+ Partials 4709 4707 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
commented
May 13, 2024
| highest = finalizedHeight | ||
| } | ||
|
|
||
| if finalizedID != executedID { |
There was a problem hiding this comment.
This check is wrong in the case where finalizedHeight < executedHeight.
janezpodhostnik
approved these changes
May 14, 2024
sideninja
approved these changes
May 14, 2024
zhangchiqing
force-pushed
the
leo/fix-get-highest-executed-and-finalized
branch
from
f0df93e
to
6a5f20a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in GetHighestFinalizedAndExecution function.