Backport: Fix get highest executed and finalized height #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.33 #5904 +/- ##
===========================================
- Coverage 55.94% 43.75% -12.20%
===========================================
Files 353 8 -345
Lines 31192 432 -30760
===========================================
- Hits 17451 189 -17262
+ Misses 12355 238 -12117
+ Partials 1386 5 -1381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sideninja
reviewed
May 14, 2024
engine/execution/state/state.go
Outdated
Comment on lines
531
to
535
| if finalizedHeight >= executedHeight { | ||
| finalizedID, err = s.headers.BlockIDByHeight(executedHeight) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("could not get header by height %v: %w", executedHeight, err) | ||
| } | ||
| highest = executedHeight | ||
| } else { | ||
| finalizedID, err = s.headers.BlockIDByHeight(finalizedHeight) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("could not get header by height %v: %w", executedHeight, err) | ||
| } | ||
| highest = finalizedHeight | ||
| } |
There was a problem hiding this comment.
maybe:
highest := math.Max(executedHeight, finalizedHeight)
sideninja
approved these changes
May 14, 2024
zhangchiqing
force-pushed
the
leo/v0.33-fix-get-highest-executed-and-finalized
branch
from
a8426a5
to
fbf24e0
Compare
janezpodhostnik
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #5903