Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle errors that come from the actual app. #1035

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Better handle errors that come from the actual app. #1035

merged 1 commit into from
Feb 18, 2021

Commits on Feb 12, 2021

  1. Better handle errors that come from the actual app. 

    As a consequence of the changes that were merged in #689, errors
thrown by strategies that utilize other_phase (or more specifically
call_app!), would be caught by omniauth, causing headaches for folks
looking to have those errors handled by their application. This
should allow for errors that come from the app to pass through, while
passing errors that come from the authentication phases to the fail!
handler.
    @BobbyMcWho
    BobbyMcWho committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    6f4cdb0 View commit details
    Browse the repository at this point in the history