Better handle errors that come from the actual app. #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a consequence of the changes that were merged in #689, errors thrown by strategies that utilize other_phase (or more specifically call_app!), would be caught by omniauth, causing headaches for folks looking to have those errors handled by their application. This should allow for errors that come from the app to pass through, while passing errors that come from the authentication phases to the fail! handler.
stnert
approved these changes
Feb 14, 2021
pgwillia
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
This works for me. I can't think of a situation where the environment variable solution shouldn't work. The tests illustrate the exact situation that we experienced. Thanks @BobbyMcWho
| @@ -462,6 +466,9 @@ def query_string | |||
|
|
|||
| def call_app!(env = @env) | |||
| @app.call(env) | |||
| rescue StandardError => e | |||
There was a problem hiding this comment.
I was wondering if it would be possible to rescue a subclass of StandardError like OmniAuthError or something like that. I guess the challenge is that call_app is called from the other dependent gems (omniauth-saml, etc) and you can't really know what will be raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consequence of the changes that were merged in #689, errors
thrown by strategies that utilize other_phase (or more specifically
call_app!), would be caught by omniauth, causing headaches for folks
looking to have those errors handled by their application. This
should allow for errors that come from the app to pass through, while
passing errors that come from the authentication phases to the fail!
handler.
Resolves #1030