Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agregando componente de Editar grupo #4818

Merged
merged 16 commits into from Nov 26, 2020
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 42 additions & 0 deletions frontend/www/js/omegaup/components/group/Edit.test.ts
@@ -0,0 +1,42 @@
import { mount, shallowMount } from '@vue/test-utils';
import expect from 'expect';

import T from '../../lang';

import group_Edit from './Edit.vue';

describe('Edit.vue', () => {
it('Should handle edit view with empty scoreboards and identities', () => {
const wrapper = shallowMount(group_Edit, {
propsData: {
groupAlias: 'Hello',
groupName: 'Hello omegaUp',
countries: [{ country_id: 'MX', name: 'Mexico' }],
isOrganizer: true,
initialTab: 'members',
initialIdentities: [],
initialIdentitiesCsv: [],
initialScoreboards: [],
},
});

expect(wrapper.text()).toContain('Hello omegaUp');
});

it('Should handle edit view getting the subcomponents info', () => {
const wrapper = mount(group_Edit, {
propsData: {
groupAlias: 'Hello',
groupName: 'Hello omegaUp',
countries: [{ country_id: 'MX', name: 'Mexico' }],
isOrganizer: true,
initialTab: 'members',
initialIdentities: [],
initialIdentitiesCsv: [],
initialScoreboards: [],
},
});

expect(wrapper.text()).toContain(T.groupEditMembers);
});
});
196 changes: 196 additions & 0 deletions frontend/www/js/omegaup/components/group/Edit.vue
@@ -0,0 +1,196 @@
<template>
<div class="group-edit">
<div class="page-header">
<h1>
<span>{{ T.omegaupTitleGroupsEdit }} {{ groupName }}</span>
lhchavez marked this conversation as resolved.
Show resolved Hide resolved
</h1>
</div>
<ul class="nav nav-pills">
<li class="nav-item" role="presentation">
<a
href="#members"
lhchavez marked this conversation as resolved.
Show resolved Hide resolved
class="nav-link"
data-tab-members
:class="{ active: showTab === 'members' }"
@click="showTab = 'members'"
>{{ T.groupEditMembers }}</a
>
</li>
<li class="nav-item" role="presentation">
<a
href="#scoreboards"
class="nav-link"
data-tab-scoreboards
:class="{ active: showTab === 'scoreboards' }"
@click="showTab = 'scoreboards'"
>{{ T.groupEditScoreboards }}</a
>
</li>
<li class="nav-item" role="presentation">
<a
href="#identities"
class="nav-link"
data-tab-identities
:class="{ active: showTab === 'identities' }"
@click="showTab = 'identities'"
>{{ T.groupCreateIdentities }}</a
>
</li>
</ul>

<div class="tab-content">
<div v-if="showTab === 'members'" class="tab-pane active" role="tabpanel">
<omegaup-group-members
:identities="identities"
:identities-csv="identitiesCsv"
:group-alias="groupAlias"
:countries="countries"
@add-member="
(memberComponent, username) =>
$emit('add-member', memberComponent, username)
"
@edit-identity="
(memberComponent, identity) =>
$emit('edit-identity', memberComponent, identity)
"
@edit-identity-member="
(
memberComponent,
originalUsername,
username,
name,
country,
state,
school,
schoolId,
) =>
$emit(
'edit-identity-member',
memberComponent,
originalUsername,
username,
name,
country,
state,
school,
schoolId,
)
"
@change-password-identity="
(memberComponent, username) =>
$emit('change-password-identity', memberComponent, username)
"
@change-password-identity-member="
(memberComponent, username, password, repeatPassword) =>
$emit(
'change-password-identity-member',
memberComponent,
username,
password,
repeatPassword,
)
"
@remove="(username) => $emit('remove', username)"
@cancel="(memberComponent) => $emit('cancel', memberComponent)"
></omegaup-group-members>
</div>

<div
v-if="showTab === 'scoreboards'"
class="tab-pane active"
role="tabpanel"
>
<omegaup-group-scoreboards
:group-alias="groupAlias"
:scoreboards.sync="scoreboards"
@create-scoreboard="
(title, alias, description) =>
$emit('create-scoreboard', title, alias, description)
"
></omegaup-group-scoreboards>
</div>

<div
v-if="showTab === 'identities'"
class="tab-pane active"
role="tabpanel"
>
<omegaup-group-create-identities
:group-alias="groupAlias"
:user-error-row="userErrorRow"
@bulk-identities="
(identitiesComponent, identities) =>
$emit('bulk-identities', identitiesComponent, identities)
"
@download-identities="
(identities) => $emit('download-identities', identities)
"
@read-csv="
(identitiesComponent, fileUpload) =>
$emit('read-csv', identitiesComponent, fileUpload)
"
></omegaup-group-create-identities>
</div>
</div>
</div>
</template>

<script lang="ts">
import { Vue, Component, Prop, Watch } from 'vue-property-decorator';
import group_Identities from './Identities.vue';
import group_Members from './Members.vue';
import group_Scoreboards from './Scoreboards.vue';
import T from '../../lang';
import { dao, types } from '../../api_types';

const availableTabs = ['memebers', 'scoreboards', 'identities'];

@Component({
components: {
'omegaup-group-create-identities': group_Identities,
'omegaup-group-members': group_Members,
'omegaup-group-scoreboards': group_Scoreboards,
},
})
export default class GroupEdit extends Vue {
@Prop() groupAlias!: string;
@Prop() groupName!: string;
@Prop() countries!: dao.Countries[];
@Prop() isOrganizer!: boolean;
@Prop() initialTab!: string;
lhchavez marked this conversation as resolved.
Show resolved Hide resolved
@Prop() initialIdentities!: types.Identity[];
@Prop() initialIdentitiesCsv!: types.Identity[];
@Prop() initialScoreboards!: types.GroupScoreboard[];
lhchavez marked this conversation as resolved.
Show resolved Hide resolved

T = T;
showTab = this.initialTab;
userErrorRow = null;
lhchavez marked this conversation as resolved.
Show resolved Hide resolved
identities = this.initialIdentities;
identitiesCsv = this.initialIdentitiesCsv;
scoreboards = this.initialScoreboards;

@Watch('initialTab')
onInitialTabChanged(newValue: string): void {
if (!availableTabs.includes(this.initialTab)) {
this.showTab = 'members';
return;
}
this.showTab = newValue;
}

@Watch('initialIdentities')
onInitialIdentitiesChanged(newValue: types.Identity[]): void {
this.identities = newValue;
}

@Watch('initialIdentitiesCsv')
onInitialIdentitiesCsvChanged(newValue: types.Identity[]): void {
this.identitiesCsv = newValue;
}

@Watch('initialScoreboards')
onInitialScoreboardsChanged(newValue: types.GroupScoreboard[]): void {
this.scoreboards = newValue;
}
}
</script>