New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement graceful shutdown and propagate request context #468
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f4be1a1
feature: Implement graceful shutdown
johejo 0d81995
Update dependencies
johejo 21e7f60
add doc for wrapper interface
johejo 686756f
Update CHANGELOG.md
johejo c28a948
fix: upgrade fsnotify to v1.4.9
johejo 610ec12
fix: remove unnessary logging
johejo a4e531a
fix: wait until all connections have been closed
johejo 44ed2ff
refactor: move chan to main for testing
johejo 7c2ea54
add assert to check if stop chan is empty
johejo b620f6e
add an idiomatic for sync.WaitGroup with timeout
johejo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| package redis | ||
|
|
||
| import ( | ||
| "context" | ||
| "time" | ||
|
|
||
| "github.com/go-redis/redis/v7" | ||
| ) | ||
|
|
||
| // Client is wrapper interface for redis.Client and redis.ClusterClient. | ||
| type Client interface { | ||
| Get(ctx context.Context, key string) ([]byte, error) | ||
| Set(ctx context.Context, key string, value []byte, expiration time.Duration) error | ||
| Del(ctx context.Context, key string) error | ||
| } | ||
|
|
||
| var _ Client = (*client)(nil) | ||
|
|
||
| type client struct { | ||
| *redis.Client | ||
| } | ||
|
|
||
| func newClient(c *redis.Client) Client { | ||
| return &client{Client: c} | ||
| } | ||
|
|
||
| func (c *client) Get(ctx context.Context, key string) ([]byte, error) { | ||
| return c.WithContext(ctx).Get(key).Bytes() | ||
| } | ||
|
|
||
| func (c *client) Set(ctx context.Context, key string, value []byte, expiration time.Duration) error { | ||
| return c.WithContext(ctx).Set(key, value, expiration).Err() | ||
| } | ||
|
|
||
| func (c *client) Del(ctx context.Context, key string) error { | ||
| return c.WithContext(ctx).Del(key).Err() | ||
| } | ||
|
|
||
| var _ Client = (*clusterClient)(nil) | ||
|
|
||
| type clusterClient struct { | ||
| *redis.ClusterClient | ||
| } | ||
|
|
||
| func newClusterClient(c *redis.ClusterClient) Client { | ||
| return &clusterClient{ClusterClient: c} | ||
| } | ||
|
|
||
| func (c *clusterClient) Get(ctx context.Context, key string) ([]byte, error) { | ||
| return c.WithContext(ctx).Get(key).Bytes() | ||
| } | ||
|
|
||
| func (c *clusterClient) Set(ctx context.Context, key string, value []byte, expiration time.Duration) error { | ||
| return c.WithContext(ctx).Set(key, value, expiration).Err() | ||
| } | ||
|
|
||
| func (c *clusterClient) Del(ctx context.Context, key string) error { | ||
| return c.WithContext(ctx).Del(key).Err() | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this panic if the server never started correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like ErrServerClosed is returned even if the server is not up.
https://github.com/golang/go/blob/master/src/net/http/server.go#L2905